all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Randy Taylor <dev@rjt.dev>, Po Lu <luangruo@yahoo.com>
Cc: 54633@debbugs.gnu.org
Subject: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku, and PGTK.
Date: Wed, 30 Mar 2022 16:27:02 +0300	[thread overview]
Message-ID: <834k3f8tax.fsf@gnu.org> (raw)
In-Reply-To: <9EqAhFUloeB4kQNtbW9VlWwN8Z3sNW2ymLkuwBA1XV5j19ttoHI_X78nrUFrz_2uqvJAu2DuGDJk0SMb2XeNUZVQgsp7EmJpzWoaWemfDVg=@rjt.dev> (message from Randy Taylor on Wed, 30 Mar 2022 12:42:54 +0000)

> Date: Wed, 30 Mar 2022 12:42:54 +0000
> From: Randy Taylor <dev@rjt.dev>
> Cc: 54633@debbugs.gnu.org
> 
> When I build Emacs I specify "--without-gif".
> 
> When using PGTK:
>   - With the original code and specifying "--without-gif", here is what configure gives me: Does Emacs use a gif library?                           yes -lgif
>   - With the patch and specifying "--without-gif", I get this (as expected): Does Emacs use a gif library?                           no
>   - With the patch, if I remove "--without-gif" or specify "--with-gif=yes", I get this (as expected): Does Emacs use a gif library?                           yes -lgif
> 
> When using X11:
>   - With the original code and specifying "--without-gif", here is what configure gives me (as expected): Does Emacs use a gif library?                           no
>   - With the original code and removing "--without-gif" or specifying "--with-gif="yes", here is what configure gives me (as expected): Does Emacs use a gif library?                           yes -lgif
> 
> The check in the code for "--without-gif" only applies to X11, but not the other systems.
> This patch fixes it to apply for all the systems in that check, in the same fashion as the SVG check (see line 2660 in configure.ac).

Thanks.  But your patch touched more than just the PGTK build.  For
w32, for example, I see no reason to make any changes; do you?
Likewise for NS.

Po Lu, do you agree that only PGTK needs a fix?  If co, can you
suggest a fix for PGTK only?





  reply	other threads:[~2022-03-30 13:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30  1:45 bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku, and PGTK Randy Taylor
2022-03-30  5:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-30 12:13 ` Eli Zaretskii
2022-03-30 12:42   ` Randy Taylor
2022-03-30 13:27     ` Eli Zaretskii [this message]
2022-03-30 13:34       ` Randy Taylor
2022-03-30 13:39         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-30 13:46         ` Eli Zaretskii
2022-03-30 13:34       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-30 14:55         ` Randy Taylor
2022-04-04 14:09           ` Randy Taylor
2022-04-05  1:08             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834k3f8tax.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=54633@debbugs.gnu.org \
    --cc=dev@rjt.dev \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.