From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 55016@debbugs.gnu.org, p.stephani2@gmail.com, spepo.42@gmail.com
Subject: bug#55016: 28.1; xref-find-references finds no matches if project dir contains a space
Date: Tue, 26 Apr 2022 15:00:33 +0300 [thread overview]
Message-ID: <834k2gm4v2.fsf@gnu.org> (raw)
In-Reply-To: <5e6b8f45-0db1-1c4e-20a0-939c3d8f5b69@yandex.ru> (message from Dmitry Gutov on Tue, 26 Apr 2022 05:05:18 +0300)
> Date: Tue, 26 Apr 2022 05:05:18 +0300
> Cc: 55016@debbugs.gnu.org, p.stephani2@gmail.com, spepo.42@gmail.com
> From: Dmitry Gutov <dgutov@yandex.ru>
>
> On 25.04.2022 14:48, Eli Zaretskii wrote:
> > Ah, okay. But, after the changes you posted, which file names may
> > need unquoting, and why? The whole point of the changes is not to use
> > any file names literally in the command line passed to the shell. And
> > our low-level primitives that invoke the shell already know to unquote
> > file names, so this should "just work", no?
>
> All right, seems so. The difference with local-dir in
> xref-matches-in-directory, is that in that function the value did get
> inserted into a shell command string.
>
> At least it did before 71f8b55f46a. Now that it doesn't, I suppose it
> doesn't need to unquote either. But then again, the previous version of
> the code didn't do any "requoting" of the file names returned in the
> Find+Grep output (if they are supposed to be requoted, that is).
>
> Nor does xref-matches-in-files do any "requoting". And this function is
> frequently-used, so any problems with that approach should have already
> come up.
If we just show those file names in some window, they don't need to be
re-quoted, I think. Quoting is only needed if the resulting file
names will be passed to Lisp APIs to act on them.
next prev parent reply other threads:[~2022-04-26 12:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 4:52 bug#55016: 28.1; xref-find-references finds no matches if project dir contains a space Peter Povinec
2022-04-19 7:13 ` Eli Zaretskii
2022-04-19 17:06 ` Peter Povinec
2022-04-19 17:32 ` Eli Zaretskii
2022-04-19 17:36 ` Eli Zaretskii
2022-04-19 17:57 ` Peter Povinec
2022-04-19 18:17 ` Eli Zaretskii
2022-04-19 18:24 ` Eli Zaretskii
2022-04-24 2:00 ` Dmitry Gutov
2022-04-24 5:31 ` Eli Zaretskii
2022-04-25 2:08 ` Dmitry Gutov
2022-04-25 11:48 ` Eli Zaretskii
2022-04-26 2:05 ` Dmitry Gutov
2022-04-26 12:00 ` Eli Zaretskii [this message]
2022-04-26 12:28 ` Dmitry Gutov
2022-04-26 12:36 ` Eli Zaretskii
2022-04-27 1:57 ` Dmitry Gutov
2022-04-27 13:53 ` Eli Zaretskii
2022-04-26 1:05 ` Peter Povinec
2022-04-26 2:07 ` Dmitry Gutov
2022-04-26 4:57 ` Peter Povinec
2022-04-26 11:18 ` Eli Zaretskii
2022-04-26 12:30 ` Dmitry Gutov
2022-04-27 3:00 ` Peter Povinec
2022-10-31 1:00 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834k2gm4v2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55016@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=p.stephani2@gmail.com \
--cc=spepo.42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.