From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55070: 28.1; desktop-load doesn't work in -nw (non-gui) emacs Date: Thu, 05 May 2022 19:51:00 +0300 Message-ID: <834k233ouj.fsf@gnu.org> References: <83fsm4pbs4.fsf@gnu.org> <6961B895-263C-4632-AA4E-8DE29D6160BC@swenson.org> <83sfq3op15.fsf@gnu.org> <86wnfcxnvf.fsf@mail.linkov.net> <87mtg8i1za.fsf@gnus.org> <86h76fu9q5.fsf@mail.linkov.net> <83r15jltce.fsf@gnu.org> <86sfpzspz4.fsf@mail.linkov.net> <83o80nlnjm.fsf@gnu.org> <86fslysc14.fsf@mail.linkov.net> <19755688-1BC3-45A0-854D-031469E50DB9@swenson.org> <861qxhy9cz.fsf@mail.linkov.net> <5DA5751F-DC2F-4C40-AE30-DAF65BCF0572@swenson.org> <86a6c56ra5.fsf@mail.linkov.net> <83wnf77yii.fsf@gnu.org> <86wnf5f8of.fsf@mail.linkov.net> <83levi4lyy.fsf@gnu.org> <86pmkufql3.fsf@mail.linkov.net> <83fslq4gik.fsf@gnu.org> <86ilqkrntx.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19310"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eric@swenson.org, 55070@debbugs.gnu.org, larsi@gnus.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 05 19:02:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmes5-0004t5-M1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 19:02:33 +0200 Original-Received: from localhost ([::1]:44200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmes4-00020U-Gq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 13:02:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmehu-0008MR-Hp for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 12:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52498) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmehu-00065L-8q for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 12:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nmehu-00083b-7k for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 12:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 May 2022 16:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55070 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 55070-submit@debbugs.gnu.org id=B55070.165176948330907 (code B ref 55070); Thu, 05 May 2022 16:52:02 +0000 Original-Received: (at 55070) by debbugs.gnu.org; 5 May 2022 16:51:23 +0000 Original-Received: from localhost ([127.0.0.1]:46389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmehG-00082R-UG for submit@debbugs.gnu.org; Thu, 05 May 2022 12:51:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmehE-000827-Vz for 55070@debbugs.gnu.org; Thu, 05 May 2022 12:51:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54888) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeh8-0005tV-Jn; Thu, 05 May 2022 12:51:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=f/HTxwAleaCuN+hXohHSIpHj5YfcoqUDYuNFMIVOUto=; b=CxxRk+6DdBeS iqoSVVVuTbucT/jAwLocPENb2M5Z8bCbsY15L6dzDdkq3I8fQOtVo+ORMBvo0ir86o7gCTBUiZF1p iEEsHUa5O5N+lbxKNqxecUkpQbDnLBZ/o8SlG68JONBPqZKkYsCt6XGoOgxD7LWNLzsj31WV/3r2Q 0x9n+jvlZYqe01PILwaa9EDaS2EzoBvFuB0oz2GRwC9bFvxdmtcMHn5N994/1kytEAuJdP2slq0U2 0EB955UIXboeVNifrKNpDAYJ423RO1oCohTCCTjGLCUqd/OVmb2JINCl7ZHfXNrUvHRf/WbM+vrNh JmuE0UEGYsulj556zT/AYQ==; Original-Received: from [87.69.77.57] (port=1512 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmeh7-0007Bf-T4; Thu, 05 May 2022 12:51:14 -0400 In-Reply-To: <86ilqkrntx.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 05 May 2022 19:35:06 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231452 Archived-At: > From: Juri Linkov > Cc: eric@swenson.org, larsi@gnus.org, 55070@debbugs.gnu.org > Date: Thu, 05 May 2022 19:35:06 +0300 > > >> Agreed. Although currently I have no idea how to do this without adding > >> direct calls of tab-bar.el functions in desktop.el. > > > > It isn't a crime. It is also not a catastrophe to have in desktop.el > > code that knows something about tab-bar.el's code. We already have > > such code in desktop.el that knows something about some minor modes. > > So now this is implemented in the attached patch. The call to > tab-bar-mode takes care about recalculating the correct values > of the tab-bar-line frame parameter. Thanks, it LGTM, but please explain in a comment to that code why this has to be done when restoring frames.