From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Implementing image support for kitty terminal Date: Thu, 08 Sep 2022 08:30:38 +0300 Message-ID: <834jxih1q9.fsf@gnu.org> References: <87v8pz18wf.fsf@mail.jao.io> <83o7vrgimc.fsf@gnu.org> <87fsh3yq81.fsf@mail.jao.io> <837d2fgef0.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2358"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jao@gnu.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 08 07:34:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWAAw-0000O1-PV for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Sep 2022 07:34:06 +0200 Original-Received: from localhost ([::1]:56684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWAAv-0007Zo-SH for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Sep 2022 01:34:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWA7x-0005dE-2C for emacs-devel@gnu.org; Thu, 08 Sep 2022 01:31:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34962) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWA7w-0008U6-2n; Thu, 08 Sep 2022 01:31:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=F/peu5JSH8e4bv/xfcKjqyLy9KkMfFrzcS7vAcXxS4g=; b=KlN70mANK4I4 UQQjQ6+3kYLJ/uXA2PJvEQS+Yu1UqXtZ34zFSz3uTdM7O+bmLVSdq/y3dctXepX7Sx69SFgo9LtQX 7A6VdTxocY0ekHXOv/oi6Y1PDimuaFpEFUAdOZ5AMlyfV4NGrbHzdv5mxAgPpHmyQuMtYtEJ64KgQ Wf1q9ZNEFmGbUWEDIDKHzvHPw6JEfXOf8vpC+4U4kBVgiyC1N9izNbIN3ltCzCZRQFnSX/3t4WIAh jqwj/NsFt22jGC3AU6XXY53rerfo7CZaIY2Dp1KjlI+axJNcAreLPbVZj5ueaaiBqO19xoL/tN0lL 1b1K7fa/XTHB/Qdjl3oVPQ==; Original-Received: from [87.69.77.57] (port=2159 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWA7q-0003vX-RD; Thu, 08 Sep 2022 01:30:59 -0400 In-Reply-To: (message from Stefan Monnier on Wed, 07 Sep 2022 16:11:01 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294899 Archived-At: > From: Stefan Monnier > Cc: Jose A Ortega Ruiz , emacs-devel@gnu.org > Date: Wed, 07 Sep 2022 16:11:01 -0400 > > > That's exactly the problem: it currently assumes that no display > > element takes more than one row, and that each row is exactly one > > pixel (= one character height) tall. > > So the change will/would need to make the glyph matrices (and their > generation) more like those used in the GUI code. That's the "hard way". It will require changes in many places that assume the current TTY geometry of the glyph rows. The problem, I think, is not with generating the matrices, it's with using them, and with adjusting features like scrolling, that currently assume all screen lines have the same height, to this change. I hoped we could avoid that, but maybe not.