From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix Date: Sat, 24 Sep 2022 08:46:20 +0300 Message-ID: <834jwxpbo3.fsf@gnu.org> References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> <878rm9om7q.fsf@elite.giraud> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3391"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58028@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 24 07:47:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oby0v-0000m6-W6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Sep 2022 07:47:46 +0200 Original-Received: from localhost ([::1]:60004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oby0u-0007tj-QU for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Sep 2022 01:47:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oby0F-0007r9-WA for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2022 01:47:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43039) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oby0F-00085N-MP for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2022 01:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oby0E-0004Pg-HX for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2022 01:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Sep 2022 05:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58028 X-GNU-PR-Package: emacs Original-Received: via spool by 58028-submit@debbugs.gnu.org id=B58028.166399840216939 (code B ref 58028); Sat, 24 Sep 2022 05:47:02 +0000 Original-Received: (at 58028) by debbugs.gnu.org; 24 Sep 2022 05:46:42 +0000 Original-Received: from localhost ([127.0.0.1]:42117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obxzu-0004P9-0U for submit@debbugs.gnu.org; Sat, 24 Sep 2022 01:46:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obxzs-0004Ow-BO for 58028@debbugs.gnu.org; Sat, 24 Sep 2022 01:46:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obxzm-00083I-PR; Sat, 24 Sep 2022 01:46:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=DMD4iukuP/GgcAMJrm7xJhIym9HT3oqT/+il6fXIrTI=; b=lwXkDKW/0UKT8na3EMNs L+gMUrlBge5oBwUmF7TQ4K8rv7djj878ZbyuH8fvCrU9+VsL6wERIJeVajoGoCF9MfXhYK8WKgBEx 3IRbzZ2qlwW0lpoQJSkOyD+7kBWhYi1D7U7tCwyLK0ruaBkwQY9Gr/gwO5i3yqMTmzQwNB3FZHNVw LZUOtQoevqVHmP/77S+MPzoD/rJeKmW4UjNAZNW0U7/q4QwYmYJLwfFeC1NjXI5lL0aG4492s+gJY 8UEV8SJm9uryIlPNFJ08jn+kh06WHRmkARom1PbCyPmWuqMFmg1VE6QtSPvn+LcLfBQZYI2Hq7BId PjKvRtRiGLEZ4Q==; Original-Received: from [87.69.77.57] (port=4829 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obxzl-0001nu-VX; Sat, 24 Sep 2022 01:46:34 -0400 In-Reply-To: <878rm9om7q.fsf@elite.giraud> (message from Manuel Giraud on Fri, 23 Sep 2022 22:43:53 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243503 Archived-At: > From: Manuel Giraud > Cc: 58028@debbugs.gnu.org > Date: Fri, 23 Sep 2022 22:43:53 +0200 > > Eli Zaretskii writes: > > >> From: Manuel Giraud > >> Cc: 58028@debbugs.gnu.org > >> Date: Fri, 23 Sep 2022 17:59:48 +0200 > >> > >> Eli Zaretskii writes: > >> > >> >> From: Manuel Giraud > >> >> Date: Fri, 23 Sep 2022 17:22:07 +0200 > >> >> > >> >> Maybe this problem never triggers. It is a « better be safe » kind of > >> >> patch. > >> > > >> > Please add an assertion there, to catch the case that previously was > >> > handled by testing only w->desired_matrix. > >> > >> I do not understand what you mean here. > > > > I mean the assertion that triggers when w->desired_matrix is NULL, but > > w->current_matrix isn't. > > Oh I see. I add the following: > --8<---------------cut here---------------start------------->8--- > eassert ((w->desired_matrix == NULL) && > (w->current_matrix != NULL)); > --8<---------------cut here---------------end--------------->8--- > > and test a little bit with emacs -Q and nothing break. So I think > you're right: when w->desired_matrix is NULL, both are. Yes, that's what I meant. So we can install your change with the above assertion added, and then wait for the assertion to trigger and investigate the case(s) where it triggers to see whether we are missing something. Thanks.