From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 31945b6c3f: * lisp/progmodes/eglot.el (eglot): Ensure managed-major-mode is a list Date: Fri, 28 Oct 2022 08:42:30 +0300 Message-ID: <834jvold15.fsf@gnu.org> References: <166668943749.31970.9379739764487638921@vcs2.savannah.gnu.org> <20221025091717.DD9A3C0E4BF@vcs2.savannah.gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3416"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com, emacs-devel@gnu.org, stephen_leake@stephe-leake.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 28 07:44:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooIA5-0000jI-1o for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Oct 2022 07:44:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooI8o-0004rJ-UA; Fri, 28 Oct 2022 01:42:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooI8l-0004qP-K6 for emacs-devel@gnu.org; Fri, 28 Oct 2022 01:42:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooI8l-0004qJ-5c; Fri, 28 Oct 2022 01:42:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iznQLSePXCaA7/h3yBiYpIM/oNVpIrzEOL6ZIsqhUFM=; b=rdtcHK/UQzk4 aAYmd+ir3aw5qx225Nr77uULu+n3ugcay/IwxpxA98iYpa0qf0jaR7tqh1oppoSqBy6z5VLfveU66 Qyo4xHZxlyvOQNOEwWyXN4ZXlcU3+Mho3qt/twR+KLHpku2VOxfllMM9pxcN5gTRlrSrBPEgb34IR XGP/taQs9pbTqVq5ze2tS/PJGz/HScdu6C6pMh+uKJN609lg3XeRcyEVytEuEDKRdl3vR97bbtmtp PeyrhTWysFynv6lx1iesDP7EWNsKdgfFw9YZ34mpZk6P/JoMo+t20MocXEhHOMnAbHRO+u4SrMXMI M+gvfTl7/tMne129zbP66A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooI8a-0002i4-Ri; Fri, 28 Oct 2022 01:42:37 -0400 In-Reply-To: (message from Richard Stallman on Thu, 27 Oct 2022 16:13:03 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298655 Archived-At: > From: Richard Stallman > Cc: emacs-devel@gnu.org, stephen_leake@stephe-leake.org > Date: Thu, 27 Oct 2022 16:13:03 -0400 > > > Personally, I'm quite OK with reviewing whitespace-only cosmetic patches to > > that > > file, as long as they are in separate commits. > > I think that is a good approach for any program. > Whitespaces fixes that clean up the code are useful, > but it's better to keep them separate from other changes. Our project-wide preference is the other way around: we ask contributors not to make any whitespace changes except where they actually change code, or nearby.