From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58957: [PATCH] Improve Brahmi composition rules. Date: Wed, 02 Nov 2022 14:32:08 +0200 Message-ID: <834jvhbkqf.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25162"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58957@debbugs.gnu.org To: =?UTF-8?Q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0_?= =?UTF-8?Q?=E0=A4=B8=E0=A4=BF=E0=A4=82=E0=A4=B9?= Sameer Singh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 14:08:56 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqDUG-0006MA-MN for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 14:08:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqCvc-00048F-Fy; Wed, 02 Nov 2022 08:33:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqCvX-00046Z-12 for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 08:33:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqCvW-0005G6-7S for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 08:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqCvV-0002pg-UA for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 08:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 12:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58957-submit@debbugs.gnu.org id=B58957.166739234610844 (code B ref 58957); Wed, 02 Nov 2022 12:33:01 +0000 Original-Received: (at 58957) by debbugs.gnu.org; 2 Nov 2022 12:32:26 +0000 Original-Received: from localhost ([127.0.0.1]:45118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqCuv-0002oq-Km for submit@debbugs.gnu.org; Wed, 02 Nov 2022 08:32:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqCut-0002oc-Qo for 58957@debbugs.gnu.org; Wed, 02 Nov 2022 08:32:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqCuo-00053s-Ha; Wed, 02 Nov 2022 08:32:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ZeNEpk2efbfIp7VSVSTrkxklXy4/7wPGP4iU3IEFmL0=; b=nXzrAHWjgVQCYuF87BP6 miI8XcT5XVE43yUR8NNjy7SQeI+eQq+5h7oTOoGZoI4B/gwPrz/niVYHRv5W4Hq07X3pa0oNqTzaF 08LaJf8uhbe0YQyOF8oOuH0W/w1PeIkfslD21b+kYiK6532GgG2dvcXx/D1hprzNfZzLsOBE/HAzj CtKrf/cDJdoqn4+ld2ZhqqmeFWCWCviOVGm2+8FD/sfwvkSn9xzK7jrt3aRm+pRv7vjX7RqvhNZOE 58CkC+C4SYgL5kKkD1ema5w71rrJtoVQjc7oe4mQ/k5L1hJPtYt3E4H7Do3VzNF+uO17UomUSCGlN H13DfGxuddUVhA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqCun-0005Dk-VY; Wed, 02 Nov 2022 08:32:18 -0400 In-Reply-To: (lumarzeli30@gmail.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246864 Archived-At: > From: समीर सिंह Sameer Singh > > Date: Wed, 2 Nov 2022 08:14:09 +0530 > > On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh wrote: > > The present composition rules for Brahmi have a bug where the virama is not composed with the > consonants, I have fixed that now. I have also added support for composing velar and bilabial fricatives in > Brahmi. > > Please review the patch. Thanks. Should we perhaps introduce tests for compositions? For example, I guess you found the problems with the current rules by examining the display of some sequences of characters, so why not add a test that would make sure we never again break those composable sequences?