From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59137: [PATCH] To minor changes related to overlays Date: Thu, 10 Nov 2022 12:38:26 +0200 Message-ID: <834jv7rt5p.fsf@gnu.org> References: <87edudm43j.fsf@rfc20.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20116"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59137@debbugs.gnu.org To: Matt Armstrong , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 10 11:39:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ot4xt-00051J-GM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Nov 2022 11:39:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ot4xk-00068s-KG; Thu, 10 Nov 2022 05:39:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot4xa-00061O-70 for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 05:39:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ot4xZ-000542-UK for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 05:39:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ot4xZ-00088e-QH for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 05:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Nov 2022 10:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59137 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59137-submit@debbugs.gnu.org id=B59137.166807672431260 (code B ref 59137); Thu, 10 Nov 2022 10:39:01 +0000 Original-Received: (at 59137) by debbugs.gnu.org; 10 Nov 2022 10:38:44 +0000 Original-Received: from localhost ([127.0.0.1]:42038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot4xI-000888-7T for submit@debbugs.gnu.org; Thu, 10 Nov 2022 05:38:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot4xG-00087t-Bb for 59137@debbugs.gnu.org; Thu, 10 Nov 2022 05:38:42 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot4xA-00050O-3L; Thu, 10 Nov 2022 05:38:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UaSfT1az+Kc64Qb+VNd6MP3mMqgYnAeDqHT680KbqVM=; b=cMvHh83MdfW7 MCGp7OHEnLten9sOcZQ/NSo4oSwOtcawcK+WCNm1I3L6KiCT0zT4ih+rq3ES6J9NfcHpzUSpEoBOz p9u3Y6JbyqAvhTOTGLbMeQbqQuYRUNla5CAIPPS4wqq1htqf3q6k7qDLOyPNbn24gZyoSyEMi8sbm DlwdMrt2biUNIXu5jHFYObAb7V03880fbq8BCp82GHahyqzTjI/YNwFfSOzXK8gJHQLoHUOu10tgq bhj7HggnQAkXtXofSd2wVkmZN3teZauTY3k0SkyWC9zyePewHsZ9mwdTZ/HtxHQxkmfjpHcD3s9yg raNF43rcGkmGEeOtcfbwDQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot4x0-0001Fx-3H; Thu, 10 Nov 2022 05:38:35 -0500 In-Reply-To: <87edudm43j.fsf@rfc20.org> (message from Matt Armstrong on Tue, 08 Nov 2022 15:14:08 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247507 Archived-At: > From: Matt Armstrong > Date: Tue, 08 Nov 2022 15:14:08 -0800 > > Tags: patch > > X-Debbugs-CC: Stefan Monnier Stefan, any comments? I have just one nit: > diff --git a/src/itree.c b/src/itree.c > index 989173db4e5..74199db3e42 100644 > --- a/src/itree.c > +++ b/src/itree.c > @@ -1431,6 +1431,9 @@ itree_iterator_next (struct itree_iterator *g) > after it was pushed: Check if it still intersects. */ > } while (node && ! interval_node_intersects (node, g->begin, g->end)); > > + if (!node) > + itree_iterator_finish(g); ^ Please leave one space between the function's name and the open parenthesis of the argument list. Thanks.