From: Eli Zaretskii <eliz@gnu.org>
To: arstoffel@gmail.com, Robert Pluim <rpluim@gmail.com>
Cc: 61553-done@debbugs.gnu.org
Subject: bug#61553: 29.0.60; Inconsistent use of dialog boxes by read-multiple-choice
Date: Sun, 19 Feb 2023 11:32:26 +0200 [thread overview]
Message-ID: <834jrixaol.fsf@gnu.org> (raw)
In-Reply-To: <83a61d2wmp.fsf@gnu.org> (message from Eli Zaretskii on Thu, 16 Feb 2023 22:17:18 +0200)
> Cc: 61553@debbugs.gnu.org
> Date: Thu, 16 Feb 2023 22:17:18 +0200
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: Augusto Stoffel <arstoffel@gmail.com>
> > Cc: 61553@debbugs.gnu.org
> > Date: Thu, 16 Feb 2023 19:36:36 +0100
> >
> > On Thu, 16 Feb 2023 at 19:59, Eli Zaretskii wrote:
> >
> > >> (read-multiple-choice "Question" '((?y "yes") (?n "no")) nil nil t)
> > >>
> > >> Then I get a minibuffer query, but I would expect a dialog box in the
> > >> case as well.
> > >
> > > The long-form call does a completing-read, and we don't support that
> > > via GUI dialogs (how could we?).
> >
> > Of course. The point is what takes precedence: the decision to prefer a
> > dialog over keyboard input, or the decision to do a completing-read
> > instead of reading a single char?
>
> I don't think the function itself can make that decision. Only the
> caller knows what's right for the context.
>
> > The purpose of long-form is to protect the user from doing something
> > dangerous by accidentally pressing a key.
>
> That's only one possible cause of using the long form. There could be
> others.
>
> > So instead of adding a special case for kill-buffer, I would rather
> > modify the behavior of RMC to just ignore the long-form argument if
> > (use-dialog-box-p) returns t. Apart from that, your patch seems fine.
>
> I disagree that rmc.el should make that decision. It isn't its call
> (pun intended).
No further comments, so I've now installed the proposed change on the
emacs-29 branch, and I'm closing this bug.
> From: Robert Pluim <rpluim@gmail.com>
> Cc: arstoffel@gmail.com, 61553@debbugs.gnu.org
> Date: Fri, 17 Feb 2023 13:42:35 +0100
>
> Eli> Oh, you assume that the reader will not understand that
> Eli> completing-read cannot possibly use GUI dialogs? I'm okay with saying
> Eli> that explicitly, although someone who uses these APIs must already
> Eli> realize that.
>
> I had to read it carefully to realize that the 'instead' referred to
> the use of dialogs.
I've made this aspect more explicit in the doc string, thanks.
prev parent reply other threads:[~2023-02-19 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 16:19 bug#61553: 29.0.60; Inconsistent use of dialog boxes by read-multiple-choice Augusto Stoffel
2023-02-16 17:59 ` Eli Zaretskii
2023-02-16 18:36 ` Augusto Stoffel
2023-02-16 20:17 ` Eli Zaretskii
2023-02-17 10:24 ` Robert Pluim
2023-02-17 12:31 ` Eli Zaretskii
2023-02-17 12:42 ` Robert Pluim
2023-02-19 9:32 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834jrixaol.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61553-done@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.