From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Finalizing 'inhibit-automatic-native-compilation' Date: Mon, 20 Feb 2023 18:57:10 +0200 Message-ID: <834jrguvfd.fsf@gnu.org> References: <20230218.061335.1468428093197134401.tats%nobody@tats.iris.ne.jp> <837cwcwnpf.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29548"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, tats@debian.org, emacs-devel@gnu.org, spwhitton@spwhitton.name, 1021842@bugs.debian.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 20 17:57:51 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pU9U6-0007XG-Ka for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Feb 2023 17:57:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pU9TR-0007AI-51; Mon, 20 Feb 2023 11:57:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU9TP-0007A7-Ej for emacs-devel@gnu.org; Mon, 20 Feb 2023 11:57:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU9TN-0000p6-9z; Mon, 20 Feb 2023 11:57:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hdef1kLXxDj76G9hbpSuz0cGOhWWgJi9cBsq318BL7w=; b=o4WwgPb7DAPW HqyHMGGrSfzwZISd+ZYoOUolEGW78oNkqbZuAuYYaYcYN6OHvztNhT199Bq6JwhKjHIoNhnKbLZgg rlqVrp+hkdtne+o5oQjQ198YRt9Mo09hVSP3Ayrf13e7yR6AKeDnkpkfqIFQL1+CuGzVBdfThUcKv /HJfaJB8pmN80BmpKzsCBTw0/405vXFcZNEnSeMcAN6XwUZCuYBpg4XJkWMArjCM51btWTUbNJTNQ GSE+ABGQ7bGb5rY+eUv/HcTOmp7kLQDB7Qqn3qXRDsKpM8F/4KZ88BhseMdokkHnHTS1KUT8Rp5VC xk6gcQ7SFqRCR4dmGDn0Mg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pU9TJ-0006aI-FO; Mon, 20 Feb 2023 11:57:04 -0500 In-Reply-To: (message from Andrea Corallo on Mon, 20 Feb 2023 15:42:08 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303615 Archived-At: > From: Andrea Corallo > Cc: monnier@iro.umontreal.ca, tats@debian.org, emacs-devel@gnu.org, > spwhitton@spwhitton.name, 1021842@bugs.debian.org > Date: Mon, 20 Feb 2023 15:42:08 +0000 > > > You mean, from master to emacs-29, I guess? > > Yes > > > What was the motivation for that change? The log message doesn't > > explain the problem it meant to solve in enough detail, it just says > > something about creating the file twice? How can that happen? who > > creates the file the second time? > > Before e6043641d30 the file was created by Fmake_temp_file_internal and > afterwards overwritten by libgccjit. So I guess one could remove the > file after the first creation and make it a link pointing to some other > file waiting for libgccjit to do its write. Then it's okay to cherry-pick it to emacs-29. (I actually am not sure why we didn't install it on emacs-29 to begin with, but never mind.) Thanks.