From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61326: [DRAFT PATCH v4] Work around zip's filename extension limitation (was: Adding --no-add-suffix to zip patch) Date: Sat, 11 Mar 2023 10:54:36 +0200 Message-ID: <834jqry8fn.fsf@gnu.org> References: <87ilgeoc4w.fsf@tullinup.koldfront.dk> <8574C128-9560-490A-88E6-49E415BBDB24@netyu.xyz> <83k00up32i.fsf@gnu.org> <83bkm4nihw.fsf@gnu.org> <83zg8sahin.fsf@gnu.org> <83jzzwa6u3.fsf@gnu.org> <83h6uz8ac4.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20421"; mail-complaints-to="usenet@ciao.gmane.io" Cc: asjo@koldfront.dk, 61326@debbugs.gnu.org To: Ruijie Yu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 11 09:55:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pav0V-00054c-01 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Mar 2023 09:55:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pav0K-00074V-Gq; Sat, 11 Mar 2023 03:55:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pav0J-00072F-29 for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 03:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pav0I-0005za-Ly for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 03:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pav0I-0006iR-Cu for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 03:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Mar 2023 08:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61326 X-GNU-PR-Package: emacs Original-Received: via spool by 61326-submit@debbugs.gnu.org id=B61326.167852490025802 (code B ref 61326); Sat, 11 Mar 2023 08:55:02 +0000 Original-Received: (at 61326) by debbugs.gnu.org; 11 Mar 2023 08:55:00 +0000 Original-Received: from localhost ([127.0.0.1]:56523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pav0F-0006i6-TQ for submit@debbugs.gnu.org; Sat, 11 Mar 2023 03:55:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pav0E-0006ht-Ks for 61326@debbugs.gnu.org; Sat, 11 Mar 2023 03:54:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pav07-0005yI-T6; Sat, 11 Mar 2023 03:54:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SnAHXJK1s9ZPdwqfKyr6bjMqCQQs44KQivMLFImc2wE=; b=iiGDJqokA2MQ WoslRzpkgaGHGJKSRBq2zyP5d/kWn56D9gUpTNfDGlTaK+pSQbwVzkfUkw1d7jb4/U+5FwyLnhR9p 6Ok5gbzuqFao5IAOjk70uEEZcqaoeqgxyuwZZG4KqPsozgaq6q6ohKyBUjmojDPFmM5h8TE54Qun0 Q+t9hWBnpRnYHFS8LSBaNLtk8m3bahI0pKDhzdCYOcC+WRwh1OU1jf959sskEfgOQFlubRuEoDE62 LoMjAjXGKp+HtpiCUtcuZdVnw5wo8ldjwkrP9ZV2vRrSguYQ2UBknRSYx0irbeQ4xGnsXlkAyWR0y VmKRMpEUCABSp8niO/CQgQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pav07-0002P0-9E; Sat, 11 Mar 2023 03:54:51 -0500 In-Reply-To: (message from Ruijie Yu on Mon, 06 Mar 2023 12:05:23 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257765 Archived-At: > From: Ruijie Yu > Cc: asjo@koldfront.dk, 61326@debbugs.gnu.org > Date: Mon, 06 Mar 2023 12:05:23 +0800 > > In the attached patches I followed the alternative approach which I > described in my previous message: take the meat of the function into a > separate helper function, and use that in the `archive-expunge' function > and in my new test. If someone else has a good reason for using prefix > argument to "force" deletion, they can ask in a new bug report. > > Another question regarding this change: when moving `archive-expunge' > into `archive--expunge-maybe-force', I rewrote the portion that > populates the list of files that are marked for deletion. Originally it > was using `while' + `setq', and seeing that arc-mode.el already requires > `cl-lib', I turned it into a `cl-do' construct. Do people have a > preference or does it matter? I can change this portion back to the > original if there's objection. I don't object in principle, but in this case it looks like the implementation based on cl-do needs much more complex code than the original? If so, I'd prefer the original, simpler and easier-to-understand code. > To ease the review process, I have broken down the changes into two > patch files. The first one is merely to take out `archive-expunge' into > helper function `archive--expunge-maybe-force', and the second one is > everything else, including the tests. > > The goal for the final patch is to combine these two into one, to make > necessary indentation changes around the portions that I touched, and to > only use the commit message of the second patch _verbatim_ -- so please > verify that this commit message is satisfactory in emacs.git, thanks. The commit log message is not detailed enough: it doesn't mention the functions you modify. Please see the conventions we follow for log messages described in CONTRIBUTE, which also mentions useful Emacs functions which will help you format the log message according to our conventions. Thanks.