From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Wed, 12 Apr 2023 11:10:23 +0300 Message-ID: <834jpl8qs0.fsf@gnu.org> References: <87a5zj2vfo.fsf@gmail.com> <87wn2modrm.fsf@posteo.net> <87ile6o2ov.fsf@posteo.net> <87y1mz38rl.fsf@posteo.net> <87ile2n0kn.fsf@gmail.com> <83r0sp8xih.fsf@gnu.org> <87bkjta6jv.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3726"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 62720@debbugs.gnu.org, monnier@iro.umontreal.ca, joaotavora@gmail.com To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 12 10:10:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmVYY-0000nJ-4P for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Apr 2023 10:10:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmVYJ-0002HD-Oh; Wed, 12 Apr 2023 04:10:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmVYI-0002Gs-0L for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 04:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmVYH-000635-P6 for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 04:10:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pmVYH-000333-Ii for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 04:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Apr 2023 08:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168128698911692 (code B ref 62720); Wed, 12 Apr 2023 08:10:01 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 12 Apr 2023 08:09:49 +0000 Original-Received: from localhost ([127.0.0.1]:38977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmVY5-00032V-5H for submit@debbugs.gnu.org; Wed, 12 Apr 2023 04:09:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmVY1-00032H-U0 for 62720@debbugs.gnu.org; Wed, 12 Apr 2023 04:09:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmVXv-0005xk-QZ; Wed, 12 Apr 2023 04:09:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6ZJlbLQ9b2BFbJ0yuw27wDDCxVoUM6dVPS449By9MlY=; b=PSfF7o4aA/JJ 5wP4khpktJXdm8Wlft3ofB3I6TVriPRCO397rx/5MDojnoQrm9JKOszQS8+KwCvoGVXGahF19R1Xl QwfDcoJGGJeS/ac0gSXfz77GCRvbz/U7fMuCxLnIQPhLtQbGcBqZuQtNyp4GhvYxQVajUWupFcgEu yByaJ+qZLatTi7/UHzetNIifAXD7wCgFpccPy2T9rK+B0NDMnjL5TaeNVxr6Uc6RiNHeIdT7PVk97 IiCaq7VkH2AX0/xFWi8TuHjFAVfm+cTMsqK0Y0kR4rfSgJaPTeK78tR4jjgXGD8t93jHXH3okv/Py 1kyyCRiN2eUlHlZvBfGf/w==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmVXv-0001X6-83; Wed, 12 Apr 2023 04:09:39 -0400 In-Reply-To: <87bkjta6jv.fsf@posteo.net> (message from Philip Kaludercic on Wed, 12 Apr 2023 07:44:20 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259710 Archived-At: > From: Philip Kaludercic > Cc: Stefan Monnier , joaotavora@gmail.com, > 62720@debbugs.gnu.org, larsi@gnus.org > Date: Wed, 12 Apr 2023 07:44:20 +0000 > > >> I'm not sure why, admittedly, but I think it comes down to the fact that > >> the first upgrade of a `:core` package from GNU ELPA feels to me more > >> like an "install" than an "upgrade". > > > > Which means my proposal of adding a new command > > package-update-core-package makes more and more sense: > > I am not sure that "core package" is necessarily a term or concept that > users would be familiar with. Or at least I have seen users confused > about the concept online, not realising that a core package can be > updated via ELPA. I'm okay with an alternative terminology, like "built-in". > How about something along the lines of `package-update-from-built-in'? Not sure about the "from" part. How about package-update-built-in instead? or maybe package-upgrade-builtin (since built-in packages will only ever be upgraded, at least normally)? > > we will > > probably need to handle such packages specially for any number of > > reasons, more so as we go with our plan to have them only on ELPA and > > "bundle" them when the release is tarred. > > Could you elaborate on this plan. Or perhaps I just lack the background > to see how these issues are related? The plan is to provide a command similar to package-update, but which will be used only for built-in packages which are also on ELPA (a.k.a. "core packages"). The internals will probably be different, since package-update offers only non-built-in packages as completion candidates, the data structures package.el uses for built-in and non-built-in packages are different, and installing an updated package should NOT delete the bundled one, just install the newer version so that it is used in preference to the bundled one. Other than that, the UI is supposed to be the same as in package-update. If something else is unclear, please ask. > > So having such a command > > now will be a good investment for the future. > > > > Philip, if this makes sense, would you please add such a command on > > the emacs-29 branch? If the exact purpose and effects of the command > > are not clear yet, let's talk about it and finalize that. > > Can do. This would prompt the user for a core package that hasn't been > installed from ELPA yet, and would make sure the package instead of the > core code is loaded? Yes. But when you say "hasn't been installed from ELPA yet", do you mean that once it has been installed, users will have to use a different command for updating it further? That might be confusing; I'd prefer that the same command is used for all the updates of built-in packages. For example, if we'd later want to support downgrading back to the bundled version, the implementation will be different for built-in packages, so having a separate command will save us some maintenance headaches. > If there is no difference in version between the ELPA and the core > package, should we say anything? Probably just user-error, I guess? Or maybe optionally provide a way of forcing the update, like if the user wants to reinstall the package anyway for whatever reasons? Thanks.