From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. Date: Mon, 05 Jun 2023 21:50:50 +0300 Message-ID: <834jnl4ub9.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39920"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63913@debbugs.gnu.org To: Morgan Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 05 20:51:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6FIX-000A6G-Ty for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Jun 2023 20:51:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6FIF-0005Gc-Fu; Mon, 05 Jun 2023 14:51:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6FIE-0005GD-6q for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 14:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6FID-0005yu-UI for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 14:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6FID-0008FW-Pm for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 14:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jun 2023 18:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63913 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63913-submit@debbugs.gnu.org id=B63913.168599106031703 (code B ref 63913); Mon, 05 Jun 2023 18:51:01 +0000 Original-Received: (at 63913) by debbugs.gnu.org; 5 Jun 2023 18:51:00 +0000 Original-Received: from localhost ([127.0.0.1]:50352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6FIC-0008FH-Ej for submit@debbugs.gnu.org; Mon, 05 Jun 2023 14:51:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6FIA-0008F4-GT for 63913@debbugs.gnu.org; Mon, 05 Jun 2023 14:50:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6FI4-0005w8-2S; Mon, 05 Jun 2023 14:50:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sKztqJUei+2Jx77exsuumT5y4zMPRy8be0FXll8Z4X0=; b=pDk+hIBf3kBP di3vHtYpfopX9Ic4gLEi9kauJVymX3h+aGS5qG2dfBDCfxjYthlX3S4okEE02jsdsV5Rk9X+zwGaQ S8tITlES+mo/hFVgOkn3iwKD5dGpSNrNq8k8M7W6BEZgoOQjjFaC17BX6/MJINE9WLNIcWclj3R1H S2U7nwE4NUbOhI9mn7pIJp46lCWq3sE2vN8GJ64o6cxpJM8T/zgDenAAHASH3szA5bYmDJhtpWEh+ hhD9VRXhz8gsvfNQXXihr4j6r1qsfEbb15yJFq6oWekYfSfi2H8Wgmi5G8me+e0+j2pI93WH5XLox 8vOCCH7pAEqzOBV1374DXQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6FI3-0007hQ-IG; Mon, 05 Jun 2023 14:50:51 -0400 In-Reply-To: (message from Morgan Smith on Mon, 05 Jun 2023 13:50:02 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263028 Archived-At: > From: Morgan Smith > Date: Mon, 05 Jun 2023 13:50:02 -0400 > > I think this patch is self-explanatory. In order to get the ding you > have to "(setopt completion-auto-help 'visible)" and try to complete > something successfully. I was doing 'M-x eshell-command-mo ' to > complete the symbol eshell-command-mode. > > I'm not sure if that's actually the complete minimal setup, but I don't > think you guys have to bother reproducing it since it's pretty obvious > my patch is an improvement. Sorry, no, it isn't obvious to me. So please do provide a complete recipe for reproducing the problem, starting frm "emacs -Q". Thanks.