all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: hi-angel@yandex.ru, emacs-devel@gnu.org
Subject: Re: ChangeLog and commit messages
Date: Mon, 19 Jun 2023 19:33:54 +0300	[thread overview]
Message-ID: <834jn38l8t.fsf@gnu.org> (raw)
In-Reply-To: <87jzw06j1y.fsf@yahoo.com> (message from Po Lu on Mon, 19 Jun 2023 14:51:53 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Mon, 19 Jun 2023 14:51:53 +0800
> 
> Konstantin Kharlamov <hi-angel@yandex.ru> writes:
> 
> > Hmm, it seems it's an SVN workflow, because in git or Mercurial you can't lock
> > file. I didn't have experience of working with SVN (fortunately, from what I can
> > tell), but I think if I had to work with it I would use `git-svn`.
> 
> Most VCS have an option to perform locked check-outs of a file.  Git and
> Mercurial are exceptions.
> 
> > Anyway, I kind of wanted to see a commit you have troubles adding a title for.
> > Judging by your first message here it's the same situation with commits to
> > Emacs, so you can drop some commit hash for example. I kind of can speculate
> > based on the general description of this SVN workflow, but it may be more
> > productive to look at specific cases where such problem arises.
> 
> If you search for ``Update Android port'' in the feature/android branch,
> you will see what I mean.

If your problems are with the feature branch, then I think you are
making your life harder than it needs to be.  Our conventions for
formatting commit log messages don't apply to feature branches.  On
feature branches, the developers are free to format the log messages
as they see fit; the only log message that matters is the one for the
merge-commit which lands the feature branch on master (which you have
to create by hand anyway).

The upshot of all this is that while you are working on a feature
branch:

  . you can use short single-line note-like log messages, which might
    be unclear to anyone but yourself
  . you should generally commit each time when you finish some
    meaningful changeset, so that it could be later reverted without
    complications -- this goes well with short log messages
  . it is futile to use "C-x 4 a"-style log messages, especially for
    changes in files or in functions the branch adds, because in the
    final commit log we only need to see "foo: New file"

This leaves you with the need to come up with a commit log for when
the branch is landed.  That might sometimes be a large job, but it
will be much smaller than the sum total of what you do now.  Moreover,
what you do now will not help you avoid this job, because we do
require3 a meaningful summary log message for when the branch is
merged.



  parent reply	other threads:[~2023-06-19 16:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87a5wxb5sl.fsf.ref@yahoo.com>
2023-06-18  7:14 ` ChangeLog and commit messages Po Lu
2023-06-18  7:39   ` Eli Zaretskii
2023-06-18  7:41     ` Po Lu
2023-06-18  8:02       ` Eli Zaretskii
2023-06-18 14:50       ` Konstantin Kharlamov
2023-06-19  0:48         ` Po Lu
2023-06-19  6:25           ` Konstantin Kharlamov
2023-06-19  6:51             ` Po Lu
2023-06-19  9:07               ` Konstantin Kharlamov
2023-06-19 10:10                 ` Po Lu
2023-06-19 11:57                   ` Dmitry Gutov
2023-06-19 16:59                     ` Eli Zaretskii
2023-06-19 17:24                       ` Dmitry Gutov
2023-06-19 22:18                   ` Konstantin Kharlamov
2023-06-19 16:33               ` Eli Zaretskii [this message]
2023-06-20  0:55                 ` Po Lu
2023-06-23  6:50                 ` Sean Whitton
2023-06-23  7:16                   ` Eli Zaretskii
2024-08-27  4:23                     ` Sean Whitton
2023-06-18  7:44   ` Sean Whitton
2023-06-18 22:38   ` Dmitry Gutov
2023-06-19  8:52   ` Jose E. Marchesi
2023-06-18 14:03 Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834jn38l8t.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=hi-angel@yandex.ru \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.