From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 b54febef5d7: Fix NetBSD build with and without ncurses Date: Sun, 16 Jul 2023 13:31:41 +0300 Message-ID: <834jm49mgi.fsf@gnu.org> References: <168940883684.23439.12214259073355647832@vcs2.savannah.gnu.org> <20230715081357.2B622C06C71@vcs2.savannah.gnu.org> <87ilak898b.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33187"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, vuori@notcom.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 16 12:32:07 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKz2s-0008NN-UC for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Jul 2023 12:32:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKz29-0008Q0-S1; Sun, 16 Jul 2023 06:31:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKz27-0008PY-3G for emacs-devel@gnu.org; Sun, 16 Jul 2023 06:31:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKz26-0000pS-7f; Sun, 16 Jul 2023 06:31:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=W14SnzlbIDWY91Y0HnJfXXF/o6OavfUjdStLYbOflm4=; b=mb+pOwNxuDZs ioUk7JmGOf6ltN8A3SENlEyPNouk0gPjYhqqc0xXubp0dBrjqufF6qXphWHwBbscZvVduWDTwHiFd 7EU5ejdzpfhp0YRUeeN9BDjhYEtFcQQfdQsbVlH0hFSO/2OcWAHZEonzlffqKqGGAQOoShcnb9Rq8 AcisLK0wfw1pZHqIhYGYFWRTZJem4s66cH5ervQlpKIOpXIoCtNFqsM/slR7oFo9Psy+9DBiR0hLM HE73DHZ1BEUdJOzj7dI9j89nGIVCngTcG80OLStxKrS7oUnyo0gz4fpV9sECxBYYfiHJU+vk7O/fs zfe18nLcZ9pmfJTsrUQPtQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKz24-0008N1-VD; Sun, 16 Jul 2023 06:31:18 -0400 In-Reply-To: <87ilak898b.fsf@yahoo.com> (message from Po Lu on Sun, 16 Jul 2023 18:02:44 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307893 Archived-At: > From: Po Lu > Cc: Valtteri Vuorikoski > Date: Sun, 16 Jul 2023 18:02:44 +0800 > > Eli Zaretskii writes: > > > - if test "x$LIBS_TERMCAP" != "x-lterminfo"; then > > + # NetBSD versions prior to 6.0 lack native terminfo, but have a > > + # tputs() built on top of termcap in these libraries. Use native > > + # termcap instead in this case. NetBSD >= 6.0 has native terminfo > > + # implementation in -lterminfo. > > + if test "x$LIBS_TERMCAP" = "x-ltermcap" -o "x$LIBS_TERMCAP" = "x-lcurses"; then > > >From (autoconf)Portable Shell: > > The `-a', `-o', `(', and `)' operands are not present in all > implementations, and have been marked obsolete by Posix 2008. This > is because there are inherent ambiguities in using them. For > example, `test "$1" -a "$2"' looks like a binary operator to check > whether two strings are both non-empty, but if `$1' is the literal > `!', then some implementations of `test'' treat it as a negation of > the unary operator `-a'. We use -o in other places with 'test'. So this is evidently not a problem. > Will anyone object if I change this to: > > AS_IF([test "x$LIBS_TERMCAP" != "x-lterminfo" \ > || test "x$LIBS_TERMCAP" = "x-lcurses"], > [...]) > > on the release branch? Please don't.