From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired Date: Fri, 04 Aug 2023 22:07:07 +0300 Message-ID: <834jlevd7o.fsf@gnu.org> References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35814"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65052@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 21:08:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qS09l-00098o-7x for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 21:08:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qS09b-0006nO-FA; Fri, 04 Aug 2023 15:08:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qS09a-0006nE-QZ for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 15:08:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qS09a-0003Lz-IW for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 15:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qS09a-0005rQ-EL for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 15:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 19:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65052 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65052-submit@debbugs.gnu.org id=B65052.169117602322462 (code B ref 65052); Fri, 04 Aug 2023 19:08:02 +0000 Original-Received: (at 65052) by debbugs.gnu.org; 4 Aug 2023 19:07:03 +0000 Original-Received: from localhost ([127.0.0.1]:54883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS08d-0005qE-Du for submit@debbugs.gnu.org; Fri, 04 Aug 2023 15:07:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qS08b-0005pi-IV for 65052@debbugs.gnu.org; Fri, 04 Aug 2023 15:07:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qS08U-0002rG-HJ; Fri, 04 Aug 2023 15:06:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OdQ46Q0lE6NogwwM/zio5cdw/oifsYG1A3kekfRs6YM=; b=AY22+0txMOvs nRQMzHmV29eYF4pvmN7m6HvLH/81RkwO3mJsu/0pNmAfbfwIz7UgTuMgGDYsFnUbkT7sAM29IECDU c9CicU122LELQ+wBKUKuZUM2Ny5+9ibIimw2F/zFjIUcw+az6VeBdl6Q9NnKI2x2+pcHtmJiIXipg MCzXYo+wx8UjMd2Ao150A23dMRoNN0KgqhyN6SoR0h2th3/135eLsaBAfjXvPvQzktjdxY7gPe/vT 4/52WHd84PZjCy0KvNLMb9xLWeCltLdp2LbWWKaunifZUblMiTG43/V0NuZ1boMm9jfMT/V/T3iP+ KwJB3WjB0DDaqNwWXkJPJw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qS08U-0006aa-5g; Fri, 04 Aug 2023 15:06:54 -0400 In-Reply-To: <87pm42psv9.fsf@ledu-giraud.fr> (message from Manuel Giraud on Fri, 04 Aug 2023 20:25:30 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266711 Archived-At: > From: Manuel Giraud > Cc: 65052@debbugs.gnu.org > Date: Fri, 04 Aug 2023 20:25:30 +0200 > > Eli Zaretskii writes: > > >> Date: Fri, 04 Aug 2023 16:55:45 +0200 > >> From: Manuel Giraud via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> Here is a patch that updates header tracking in image-dired when > >> scrolling up or down. > > > > What is "header tracking"? > > > > More generally, could you please explain what problem are you trying > > to solve here? > > Yes, sorry. When you are using image-dired, there is a header line with > some informations (by default name of the file, its size and so on, see > `image-dired-display-properties-format'). Those informations are > updated when you move from one thumbnail to another (by mean of > C-{f,b,n,p}). But they are not updated with C-v/M-v. This patch fixes > this. OK, but then this part: > + ;; "one line" dance to update tracking and header > + (image-dired-next-line) > + (image-dired-previous-line)) looks like a kludge. Can't we have a cleaner code for updating the header data? If image-dired-previous/next-line can update the data, why cannot the scroll commands do the same without calling the line-movement commands?