From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65113: Emacs-29 and master csharp-mode with broken treesit Date: Thu, 10 Aug 2023 12:05:51 +0300 Message-ID: <834jl7jmhc.fsf@gnu.org> References: <83fs4wp4hc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33781"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 65113@debbugs.gnu.org To: jean@tbm.email, Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 10 11:06:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qU1cX-0008c1-Pw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Aug 2023 11:06:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qU1cM-0006NZ-Ip; Thu, 10 Aug 2023 05:06:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU1cI-0006Lo-6E for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 05:06:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qU1cH-000611-UC for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 05:06:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qU1cH-0005vn-Pl for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 05:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Aug 2023 09:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65113 X-GNU-PR-Package: emacs Original-Received: via spool by 65113-submit@debbugs.gnu.org id=B65113.169165834022769 (code B ref 65113); Thu, 10 Aug 2023 09:06:01 +0000 Original-Received: (at 65113) by debbugs.gnu.org; 10 Aug 2023 09:05:40 +0000 Original-Received: from localhost ([127.0.0.1]:41356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU1bw-0005v9-1V for submit@debbugs.gnu.org; Thu, 10 Aug 2023 05:05:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU1bt-0005ut-6d for 65113@debbugs.gnu.org; Thu, 10 Aug 2023 05:05:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU1bi-0005qC-KG; Thu, 10 Aug 2023 05:05:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3gMFCV1EfmsYPgHPn7D2QZGYoyulHam3UKGd/Afu5ts=; b=eDOyC3E/yQKzBfg5ls7k 3pnmG42ydvzkNrtQhPzNXD2nsHnoxpEf+8zmG9CLGVhwdkHqEAJTm7Ma1+JOim5RS9yAEwX4wCXmE 7s335cjef3wiQ9UvxANhmN58tW0+9/V/GroS5HRPWEQy6d022kHnKZnu7sf0r58DXCK28v1jvJAUd V5wbHb6d5pcXEPXvoEiO2Wl1gGn7Fa5HByNagWRNDHI4qYNIBIjKKX2EApW5ppGQ4QKnyQzIHkabA FmLC+Meu2SqkFx/R6c3k39XHRQtgyKTf9JmT5NnHqPvIahmi/H/HUR4hQyJ+6O+SLlh058QsRFa+U EX8Mbme6lBLr5Q==; In-Reply-To: (message from Theodor Thornhill on Mon, 07 Aug 2023 07:46:05 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267108 Archived-At: > Date: Mon, 07 Aug 2023 07:46:05 +0200 > From: Theodor Thornhill > CC: 65113@debbugs.gnu.org Ping! Can we please have a patch that is backward-compatible? > On 6 August 2023 17:36:47 CEST, Eli Zaretskii wrote: > >> From: J M > >> Date: Sun, 6 Aug 2023 16:03:45 +0100 > >> > >> Treesit is broken for csharp-mode in the latest version in master and emacs-29 and therefore does not provide syntax highlighting.  > >> > >> The latest grammar repository (https://github.com/tree-sitter/tree-sitter-c-sharp) has removed the keyword void_keyword. > >> > >> Please see attached the patch to resolve the issue. > > > >Thanks, but your patch will not work with the older version of the > >grammar library, right? Is it possible to make a patch that will work > >with both? Wed cannot rely on users having the latest grammar > >versions, so a backward-compatible change is much more preferable. > > We've had some similar patches lately that you can use for inspiration. > > Thanks, > Theo >