From: Eli Zaretskii <eliz@gnu.org>
To: Corwin Brust <corwin@bru.st>
Cc: 65206@debbugs.gnu.org
Subject: bug#65206: 29.1; [windows][patch] build-deps-zips.py is broken and hard to maintain
Date: Wed, 16 Aug 2023 17:49:28 +0300 [thread overview]
Message-ID: <834jkz82kn.fsf@gnu.org> (raw)
In-Reply-To: <CAJf-WoSES0gt4XZMtEuCbAgoOmRZ5jc+N5wy35kztwS1075f_Q@mail.gmail.com> (message from Corwin Brust on Wed, 16 Aug 2023 08:41:25 -0500)
> From: Corwin Brust <corwin@bru.st>
> Date: Wed, 16 Aug 2023 08:41:25 -0500
> Cc: 65206@debbugs.gnu.org
>
> On Wed, Aug 16, 2023 at 7:08 AM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > I'm not sure I understand the reservation. That list mentions every
> > single DLL that we know can be used for each optional feature. If a
> > feature has more than one DLL listed, the first one is usually the
> > most popular, and should be tried first.
>
> This solves my worry completely, or nearly so.
>
> To confirm: when walking the list, I will want to take the first DLL
> mentioned that actually exists for each entry. Is that right?
Yes.
> There might not be a problem (except the one we are trying to fix).
> The alist contains 22 entries, while var DLL_REQ contains 14 entries.
> The five on the alist but on mentioned in the script (so far) are:
>
> gdiplus
> shlwapi
You can ignore those: they are for Windows 9X, and they are system
DLLs.
> gobject
> gio
These are needed for librsvg. You might get away with them because
librsvg pulls them in as second-order dependencies.
> webpdemux - this is pretty obviously a miss in the script; it does get
> however because it's required by webp which is listed in DLL_REQ
Yes, this is required by libwebp, since some of the library functions
are in lobwebpdemux.
> Are all of these errors with the script (so, the corresponding DLLs
> should be included)? If not, I think we will need a way for the
> script to know which alist entries to skip/ignore.
You should only skip the first two, which are Windows system DLLs.
> > > Does a "invokes Emacs now and errors out if stuff is missing" approach
> > > sound right/good?
> >
> > I'm not sure I understand how would you force Emacs to "error out"
> > when we are talking about optional dependencies. They are optional so
> > that Emacs could run even if they are not present.
> >
>
> Oops, badly said: I mean that my build and packaging process should
> stop and report an error if it cannot create a "complete" DEPS ZIP.
> Nothing affecting the Emacs run-time.
OK.
next prev parent reply other threads:[~2023-08-16 14:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 12:40 bug#65206: 29.1; [windows][patch] build-deps-zips.py is broken and hard to maintain Corwin Brust
2023-08-10 13:29 ` Eli Zaretskii
2023-08-10 21:09 ` Corwin Brust
2023-08-15 7:39 ` Corwin Brust
2023-08-15 15:43 ` Eli Zaretskii
2023-08-15 15:53 ` Corwin Brust
2023-08-15 16:01 ` Eli Zaretskii
2023-08-16 1:23 ` Corwin Brust
2023-08-16 12:08 ` Eli Zaretskii
2023-08-16 13:41 ` Corwin Brust
2023-08-16 14:49 ` Eli Zaretskii [this message]
2023-08-17 7:25 ` Corwin Brust
2023-08-17 9:55 ` Eli Zaretskii
2023-08-17 13:31 ` Corwin Brust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834jkz82kn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65206@debbugs.gnu.org \
--cc=corwin@bru.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.