From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66020: (bug#64735 spin-off): regarding the default for read-process-output-max Date: Thu, 21 Sep 2023 16:16:31 +0300 Message-ID: <834jjnacpc.fsf@gnu.org> References: <8334zmtwwi.fsf@gnu.org> <83tts0rkh5.fsf@gnu.org> <831qf3pd1y.fsf@gnu.org> <28a7916e-92d5-77ab-a61e-f85b59ac76b1@gutov.dev> <83sf7jnq0m.fsf@gnu.org> <5c493f86-0af5-256f-41a7-7d886ab4c5e4@gutov.dev> <83ledanvzw.fsf@gnu.org> <83r0n2m7qz.fsf@gnu.org> <26afa109-9ba3-78a3-0e68-7585ae8e3a19@gutov.dev> <83il8dna30.fsf@gnu.org> <83bke5mhvs.fsf@gnu.org> <83a5tmk79p.fsf@gnu.org> <937d9927-506f-aa36-94e9-3cceb8f629dd@gutov.dev> <83zg1hay6q.fsf@gnu.org> <451d6012-e5ab-df6c-50e3-dac20b91781c@gutov.dev> <58e9135f-915d-beb9-518a-e814ec2a0c5b@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24041"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66020@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 21 15:17:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjJYK-00061E-FB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Sep 2023 15:17:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjJY6-00037z-RR; Thu, 21 Sep 2023 09:16:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjJY5-00037o-CS for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 09:16:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjJY5-0000oV-3S for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 09:16:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjJYE-0004Xw-JC for bug-gnu-emacs@gnu.org; Thu, 21 Sep 2023 09:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Sep 2023 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66020 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66020-submit@debbugs.gnu.org id=B66020.169530220717449 (code B ref 66020); Thu, 21 Sep 2023 13:17:02 +0000 Original-Received: (at 66020) by debbugs.gnu.org; 21 Sep 2023 13:16:47 +0000 Original-Received: from localhost ([127.0.0.1]:33003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjJXy-0004XN-Nt for submit@debbugs.gnu.org; Thu, 21 Sep 2023 09:16:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjJXu-0004X7-4U for 66020@debbugs.gnu.org; Thu, 21 Sep 2023 09:16:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjJXd-0000aL-Nq; Thu, 21 Sep 2023 09:16:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BltP3jySIVDwuXLIIfafYqDJQOceK1PSJ1ImbPUVUHQ=; b=Ig5AmKuCesIA So6GnFKcU9Y0/XpYeRgrIP54tPXRl0X5l6WWN9/py/4i1N+Z06mgwhoZppAT8G92Rb/5WySL0pdoq t654H5JWezPmbhHuL1HP2/9JclMJkEvkZa714ZGxlMZoCgpLWOp6tGiWcWT7LQP6Mgx4SPdzbkMZ0 p5hE6ITr8SLcxFYD9WDo9NnpajX8hAu81gSioyv3p8p0jHALkUtbTXPHKkxgc4+/E0B8zgzr5arbo QCF33M6J2p5XdzTEJCVtH8Pv+Ysf0Od8xyD0Db4e4QZzRgdxReEzYL5w3TBvVrtN8gksaraOq7WF8 LFIcYDOiGUCFIIZuDbgj0Q==; In-Reply-To: <58e9135f-915d-beb9-518a-e814ec2a0c5b@gutov.dev> (message from Dmitry Gutov on Thu, 21 Sep 2023 15:20:57 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270989 Archived-At: > Date: Thu, 21 Sep 2023 15:20:57 +0300 > Cc: Eli Zaretskii , Stefan Kangas , > 66020@debbugs.gnu.org > From: Dmitry Gutov > > On 21/09/2023 05:36, Stefan Monnier wrote: > >> make_process), although I had to use a value produced by make_uninit_string: > >> apparently simply storing a char* field inside a managed structure creates > >> problems for the GC and early segfaults. Anyway, the result was slightly > > That should depend on*where* you put that field. Basically, it has to > > come after: > > > > /* The thread a process is linked to, or nil for any thread. */ > > Lisp_Object thread; > > /* After this point, there are no Lisp_Objects. */ > > > > since all the words up to that point will be traced by the GC (and > > assumed to be Lisp_Object fields). > > Ah, thanks. That calls for another try. > > ...still no improvement, though no statistically significant slowdown > either this time. Why did you expect a significant improvement? Allocating and freeing the same-size buffer in quick succession has got to be optimally handled by modern malloc implementations, so I wouldn't be surprised by what you discover. There should be no OS calls, just reuse of a buffer that was just recently free'd. The overhead exists, but is probably very small, so it is lost in the noise.