From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Sat, 07 Oct 2023 13:57:14 +0300 Message-ID: <834jj21z05.fsf@gnu.org> References: <878r919qfh.fsf@localhost> <72c93fb0-bf3e-3dad-69c0-2147cfa40f57@gutov.dev> <875y42xyex.fsf@localhost> <87zg1ewfc2.fsf@localhost> <834jjm749q.fsf@gnu.org> <87cyyawd1a.fsf@localhost> <83pm2a5k85.fsf@gnu.org> <87wmwh2tae.fsf@localhost> <83zg1d468w.fsf@gnu.org> <87bkdr2651.fsf@localhost> <87pm2584oz.fsf@localhost> <83cyy11ln1.fsf@gnu.org> <87lecp84mf.fsf@localhost> <83ttrdx8j9.fsf@gnu.org> <87a5su261p.fsf@localhost> <838r8e24yy.fsf@gnu.org> <87y1gezspg.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14402"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 07 12:57:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qp50N-0003T5-Vn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Oct 2023 12:57:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qp50D-0001Pv-8O; Sat, 07 Oct 2023 06:57:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qp50B-0001PK-ET for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 06:57:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qp50B-0006vN-6J for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 06:57:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qp50U-0001bF-Gv for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 06:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Oct 2023 10:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.16966762516089 (code B ref 66117); Sat, 07 Oct 2023 10:58:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 7 Oct 2023 10:57:31 +0000 Original-Received: from localhost ([127.0.0.1]:53460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp4zz-0001a9-8o for submit@debbugs.gnu.org; Sat, 07 Oct 2023 06:57:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qp4zw-0001Zs-At for 66117@debbugs.gnu.org; Sat, 07 Oct 2023 06:57:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qp4zX-0006h6-A1; Sat, 07 Oct 2023 06:57:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pbExrTj9Acmv/k7pKZLCoELl1bqv+Olq6CpbACiAqME=; b=Nm+1uelmBM80 DaC1ldmyUlHA7d89rp4epr0zDKMATtYthLa5BVR6G7faW61AIBR4F3R6kZ6QKNxZGgLKL1yb0ucVa 8lAPZ0Lm2PowpAgNZRdLjjvliUWQKGIpan9DgAbvqivv6PmErsiZZUHQbsNZv0oVMafA4JxHft0ix M2weGGuce365JATFqbSSVncXXoe6hhwxNM40T1SjacgXiUdCbugGNAf/x24Pr7W3InzI184tgtgp+ 2xkurCZKu/Ra4xy/QrrVN+T7oyKCfxjxGGhvKIyhWBVSQPdfQYVKav52qDUqDuQHg8fryRjT+52w/ fRm6vMPAnqB7ypto1deeDQ==; In-Reply-To: <87y1gezspg.fsf@localhost> (message from Ihor Radchenko on Sat, 07 Oct 2023 09:29:15 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271990 Archived-At: > From: Ihor Radchenko > Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org > Date: Sat, 07 Oct 2023 09:29:15 +0000 > > Eli Zaretskii writes: > > > From my POV, there are two alternatives here: > > > > . expose several new primitives to Lisp to make find-buffer-visiting > > faster without changing the way we store the file-to-buffer > > association information > > . introduce caches or change the way file-to-buffer associations are > > stored to speed up find-buffer-visiting > > > > What I'd like to see is that someone implements the first idea, and > > times find-buffer-visiting after that to see if it becomes fast > > enough. Then we can discuss whether anything else is needed. > > Agree. That's what I was trying to do. However, one of the new primitives > will require searching a buffer with given value of `buffer-file-number' > - the variable not defined in C. buffer-file-number is defined as follows: (file-attribute-file-identifier (file-attributes buffer-file-name))) whereas file-attribute-file-identifier is (defsubst file-attribute-file-identifier (attributes) "The inode and device numbers in ATTRIBUTES returned by `file-attributes'. The value is a list of the form (INODENUM DEVICE), where DEVICE could be either a single number or a cons cell of two numbers. This tuple of numbers uniquely identifies the file." (nthcdr 10 attributes)) So in C this is: list2 (INT_TO_INTEGER (s.st_ino), INT_TO_INTEGER (s.st_dev)); > >> For example, org-element.el needs to set buffer-local values in base > >> buffer of an indirect buffer every time buffer text is being edited. > > > > And that is performance-critical? in what way and in which situations? > > When making a large number of edits in Org buffer. The code I am > referring to runs in `after-change-functions' and therefore should be as > fast as possible. I'd need to see measurements for that. In any case, this is a separate issue.