From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: dmitry@gutov.dev, 66806@debbugs.gnu.org
Subject: bug#66806: 30.0.50; [PATCH] 'project-find-regexp' passes Git submodules to the search program
Date: Sun, 29 Oct 2023 21:22:54 +0200 [thread overview]
Message-ID: <834ji9b5dd.fsf@gnu.org> (raw)
In-Reply-To: <80277522-c366-2014-8b52-250634090f2e@gmail.com> (message from Jim Porter on Sun, 29 Oct 2023 10:54:28 -0700)
> Date: Sun, 29 Oct 2023 10:54:28 -0700
> Cc: dmitry@gutov.dev, 66806@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> >> - (project-files pr)
> >> + ;; XXX: See the comment in project-query-replace-regexp.
> >> + (cl-delete-if-not #'file-regular-p (project-files pr))
> > ^^^^^^^^^^^^^^^^
> > I think we want to prefer using seq.el functions, since seq.el is
> > nowadays preloaded. Is there a good reason to use cl-delete-if-not
> > here?
>
> Well, that's just copy-pasted from some other functions in project.el.
> If we want to go the minimal route, I could update all those workarounds.
>
> Or we could go the maximal route and fix it at its source. Here's an
> updated patch for the maximal route that uses 'seq-difference'.
That's up to Dmitry; from my POV it is enough that new code prefers
seq.el.
next prev parent reply other threads:[~2023-10-29 19:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 5:36 bug#66806: 30.0.50; [PATCH] 'project-find-regexp' passes Git submodules to the search program Jim Porter
2023-10-29 6:06 ` Eli Zaretskii
2023-10-29 17:54 ` Jim Porter
2023-10-29 19:22 ` Eli Zaretskii [this message]
2023-10-29 22:14 ` Dmitry Gutov
2023-10-29 21:41 ` Dmitry Gutov
2023-10-30 0:58 ` Jim Porter
2023-10-30 2:00 ` Dmitry Gutov
2023-10-30 3:53 ` Jim Porter
2023-10-29 22:02 ` Dmitry Gutov
2023-10-30 0:25 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834ji9b5dd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66806@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.