From: Eli Zaretskii <eliz@gnu.org>
To: Wilhelm Kirschbaum <wkirschbaum@gmail.com>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 67207@debbugs.gnu.org
Subject: bug#67207: [PATCH] Add elixir-ts-mode-hook to elixir-ts-mode
Date: Wed, 15 Nov 2023 21:58:03 +0200 [thread overview]
Message-ID: <834jhmrdpw.fsf@gnu.org> (raw)
In-Reply-To: <8734x6rdvz.fsf@gmail.com> (message from Wilhelm Kirschbaum on Wed, 15 Nov 2023 21:43:06 +0200)
> From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
> Cc: 67207@debbugs.gnu.org
> Date: Wed, 15 Nov 2023 21:43:06 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Wilhelm Kirschbaum <wkirschbaum@gmail.com>
> >> Date: Wed, 15 Nov 2023 20:32:42 +0200
> >>
> >> This change was requested by a user and seems to be useful.
> >
> > Sorry, I don't understand: what was the request of that user?
> > elixir-ts-mode is defined using define-derived-mode, which
> > automatically creates a mode hook, so why do you need to define
> > it
> > explicitly?
>
> I had exactly the same question. The user wants to manage the
> elixir-ts-mode hooks from the customize-group menu and not using
> elisp. This seems to be the way to make it show up on the
> customize-group menu for elixir-ts-mode. There are some other
> modes doing the same if you search for `defcustom .*-mode-hook`
> under the progmode folder.
>
> If this is undesirable or if there is another way to make it show
> up on the customize menu, it will be good to know.
Adding Stefan to the discussion.
Stefan, does this mean define-derived-mode has some deficiency?
Many/most modes defined using it don't have an explicit hook
definition, so should we now define a mode hook for all of them?
next prev parent reply other threads:[~2023-11-15 19:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 18:32 bug#67207: [PATCH] Add elixir-ts-mode-hook to elixir-ts-mode Wilhelm Kirschbaum
2023-11-15 19:38 ` Eli Zaretskii
2023-11-15 19:43 ` Wilhelm Kirschbaum
2023-11-15 19:58 ` Eli Zaretskii [this message]
2023-11-15 22:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-18 8:32 ` Wilhelm Kirschbaum
2023-11-19 3:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-18 10:03 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834jhmrdpw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67207@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=wkirschbaum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.