From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Word completion in text modes Date: Sat, 18 Nov 2023 21:18:44 +0200 Message-ID: <834jhina3v.fsf@gnu.org> References: <83h6ljme0j.fsf@gnu.org> <83edgnmaqw.fsf@gnu.org> <837cmfm30o.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20280"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 18 20:19:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4Qr0-00058g-25 for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Nov 2023 20:19:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4QqL-00027x-CF; Sat, 18 Nov 2023 14:19:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4QqJ-00027e-LB for emacs-devel@gnu.org; Sat, 18 Nov 2023 14:18:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4QqJ-0002hh-Ai; Sat, 18 Nov 2023 14:18:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=C2xbfyne8WVkyR3RmPM6iBUS8ZN45j/RuGxI049C9So=; b=isyKRK30swhH Js6p3bZeim1z9FknH93hBd5+12fwzw68ojHARA8bwkAhhNWfniZKiCiHFiPowVtbHj2sv+91QftjD e11sGqcu9yGhp/CMf7yWQ0wDxmC8TgCsdLu4HUAgNkr6qZ8OtNXAX+0ObG61qk231NbNnIqNoyjzJ ZsHbjD62CDccqjsVb4F2uSb2AzaQHhyB0Tk/89/7i8ka43B8XnVrSY0pdCniacT0Z5d8HRZj3kfi1 G6uaskZuMSUvoPqYglXd8LJ7hohkjbFrP9ha0ZflL/Yje13Y5/0qrC9vLCO4UHbV85kx3e1KnoHg0 sEPnlbKLu2svqJzfMyX4Tw==; In-Reply-To: (message from Eshel Yaron on Sat, 18 Nov 2023 20:03:45 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312925 Archived-At: > From: Eshel Yaron > Cc: emacs-devel@gnu.org > Date: Sat, 18 Nov 2023 20:03:45 +0100 > > Eli Zaretskii writes: > > > If we don't preserve that UI, we will be making an incompatible > > change, which from my POV is undesirable. It doesn't matter whether > > we like or dislike the ispell UI for this: compatibility means just > > that. We could make the old UI an opt-in behavior, but tossing it > > altogether is not something I'd welcome. > > I think we mostly agree then, because I didn't suggest tossing the old > UI anywhere. To opt-in to the old behavior, you'd say: > > (keymap-set text-mode-map "C-M-i" #'ispell-complete-word) > > That seems to me like a simple enough tip for users that we could appear > in a NEWS entry. Does that sound reasonable? I'd prefer a solution that didn't require key bindings. Something like a user option. > >> Either way it'd be compatible in the sense that you get the same > >> completions, and `ispell-complete-word` wouldn't go anywhere so > >> users could rebind it if they really want to. > > > > That is not compatibility in my book, sorry. We should actually offer > > a very similar or identical UI. > > Yes, I wonder just wonder how should we offer that UI. Doesn't keeping > the command around for users to make use of cover it? Or do you mean > there should be some user option for selecting the word completion UI? I think an option will be better.