From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: noah.v.peart@gmail.com, 67357@debbugs.gnu.org, dmitry@gutov.dev
Subject: bug#67357: [PATCH] Fix c-ts-mode block indent when first-siblings are comments
Date: Sun, 10 Dec 2023 11:39:31 +0200 [thread overview]
Message-ID: <834jgqwg4s.fsf@gnu.org> (raw)
In-Reply-To: <8c7e244d-5dad-4111-89b8-ca7722657ce0@gmail.com> (message from Yuan Fu on Sun, 10 Dec 2023 01:09:15 -0800)
> Date: Sun, 10 Dec 2023 01:09:15 -0800
> Cc: noah.v.peart@gmail.com, 67357@debbugs.gnu.org, dmitry@gutov.dev
> From: Yuan Fu <casouri@gmail.com>
>
>
> > Ping! Ping! Yuan, please chime is, as I'm waiting for your comments
> > before we install on the release branch.
> >
> > This and other patches for TS-based modes are currently delaying the
> > release of Emacs 29.2, so please try to be more responsive, okay?
> >
> Whoa! Sorry, I just switched to a new email client, and direct CC isn't
> highlight as they were before :-( (And admittedly I haven't been
> browsing the bug tracker lately.)
OK, but please look also at other bugs and issues where I asked for
your opinions.
> As for the patch, first of all, thank you, Noah, it's very good. I try
> to avoid query matchers since they could be slow, plus the fundamental
> problem isn't with comments, IMO. The problem is when the first sibling
> isn't on it's own line. (Though in normal C source code, when the first
> sibling isn't on its own line, that sibling is usually a comment.)
> Anyway, please see my reasoning in the commit message for 08fc6bace20.
>
> I also removed the else_clause rule since it's already added by the
> patch for bug#67417, and added another test.
Thanks, but please in the future mention _all_ relevant bug numbers
in the log message, or merge them if appropriate.
next prev parent reply other threads:[~2023-12-10 9:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 1:50 bug#67357: [PATCH] Fix c-ts-mode block indent when first-siblings are comments Noah Peart
2023-11-23 7:35 ` Eli Zaretskii
2023-11-23 13:17 ` Dmitry Gutov
2023-11-23 14:33 ` Eli Zaretskii
2023-11-23 14:41 ` Dmitry Gutov
2023-11-24 13:47 ` Noah Peart
2023-11-24 14:07 ` Eli Zaretskii
2023-11-24 14:35 ` Noah Peart
2023-11-24 14:45 ` Noah Peart
2023-11-24 14:46 ` Eli Zaretskii
2023-11-29 13:47 ` Eli Zaretskii
2023-12-09 8:23 ` Eli Zaretskii
2023-12-10 9:09 ` Yuan Fu
2023-12-10 9:39 ` Eli Zaretskii [this message]
2023-12-11 1:11 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834jgqwg4s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67357@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dmitry@gutov.dev \
--cc=noah.v.peart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.