From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67836: 29.1.90; map-y-or-n-p doesn't terminate when run in a kmacro in batch mode Date: Sat, 16 Dec 2023 15:52:34 +0200 Message-ID: <834jgimezh.fsf@gnu.org> References: <83msubo2vw.fsf@gnu.org> <835y0yo9cf.fsf@gnu.org> <87o7eqthpu.fsf@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9177"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 67836@debbugs.gnu.org, monnier@iro.umontreal.ca To: sbaugh@catern.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 16 14:54:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEV7X-00029j-Rp for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Dec 2023 14:54:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEV7J-0005Nr-Ft; Sat, 16 Dec 2023 08:54:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEV7C-00059K-29 for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 08:54:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEV7B-0003SR-Oz for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 08:54:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEV7C-0002by-2g for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 08:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Dec 2023 13:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67836 X-GNU-PR-Package: emacs Original-Received: via spool by 67836-submit@debbugs.gnu.org id=B67836.17027347909955 (code B ref 67836); Sat, 16 Dec 2023 13:54:02 +0000 Original-Received: (at 67836) by debbugs.gnu.org; 16 Dec 2023 13:53:10 +0000 Original-Received: from localhost ([127.0.0.1]:54258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEV6K-0002aS-C5 for submit@debbugs.gnu.org; Sat, 16 Dec 2023 08:53:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEV6F-0002Zq-Dg for 67836@debbugs.gnu.org; Sat, 16 Dec 2023 08:53:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEV67-0001mk-9W; Sat, 16 Dec 2023 08:52:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TW3TsftiV/Mz0NQ4Ckon2zd5JohoXLR9hD5TsasW37Q=; b=aBPU11hLe0Ca oqO9S5Wn8EgQ9Cu3BCc6ZoFEKX0mhjUN0KmUdUlVyKl4lP9AdCXl19jymrGi4/44HCxhtLpjJqEQn cUqIt+xORqg2/QifVRpDZLeoF0r0U5Xq7p8M0rmsLdvq3wfMDmjLOOgmtBrMF9KUnjt4XqvL6Knxr mxVlpBGJjPcCdSPMrhlnTzttPqCMZ10mivw+GDodiVKmdaPQzMlMIN5QsccTQ5jfp2tD792sNEAuO syh2Ql7VyGKTBSfh/AJqGlJ7Srw+ZD/ZclVuwAPqF7z7gmd9AWS9eTpoadF5JXRvulkjHrK6Muze4 H4d4JeF/Qb6WS11TzIsEmw==; In-Reply-To: <87o7eqthpu.fsf@catern.com> (sbaugh@catern.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276342 Archived-At: > From: sbaugh@catern.com > Date: Sat, 16 Dec 2023 13:13:25 +0000 (UTC) > Cc: Stefan Monnier , sbaugh@janestreet.com, > 67836@debbugs.gnu.org > > Eli Zaretskii writes: > >> > >> I suspect keyboard macros have not been used very much in batch mode > >> over the last 32 years. > > > > I actually question the wisdom of doing so. It isn't what keyboard > > macros are for. > > How else can one test keyboard interaction with Emacs commands, > including their interactive specs? I see no way to do that other than > with keyboard macros. I'd be happy to hear that there's a better way, > though. One way is by mocking of functions that read input. AFAIR we do that in several places in the test suite (which I always run in batch mode). > There is definitely at least one bug, since the docstring of ding > currently erroneously says: > > Also, unless an argument is given, > terminate any keyboard macro currently executing. > > Making ding match its docstring was one way to fix this bug. If you > don't want to do that, could you apply this patch or something like it? Will look into the documentation issue, once we agree on resolving this bug that way. > Often, a low-level change to Emacs is in fact acceptable. I have little > way of knowing whether any given low-level change is acceptable, other > than by sending it in and seeing what others say. I hope it is OK if I > continue to do that. It is definitely okay, and your work is certainly appreciated. I'm just trying to explain the POV of the Emacs maintainers, in the hope that you could look for solutions in places other than low-level code which is used all over Emacs, when problems are specific to some higher-level API or specific situation. That would make the review and acceptance of the changes more efficient, and will probably prevent you from doing extra unnecessary work.