From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt Date: Fri, 12 Jan 2024 14:08:18 +0200 Message-ID: <834jfikb4d.fsf__6528.35318339697$1705061373$gmane$org@gnu.org> References: <87v87yvnly.fsf@dataswamp.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30905"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-erc@gnu.org, 68401@debbugs.gnu.org To: Emanuel Berg Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 12 13:09:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOGLk-0007pA-6W for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jan 2024 13:09:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOGLR-0004Je-Sq; Fri, 12 Jan 2024 07:09:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOGLQ-0004JA-RD for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 07:09:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOGLQ-0007ZL-Im for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 07:09:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOGLO-0003T5-Ay for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 07:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jan 2024 12:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68401 X-GNU-PR-Package: emacs Original-Received: via spool by 68401-submit@debbugs.gnu.org id=B68401.170506132613305 (code B ref 68401); Fri, 12 Jan 2024 12:09:02 +0000 Original-Received: (at 68401) by debbugs.gnu.org; 12 Jan 2024 12:08:46 +0000 Original-Received: from localhost ([127.0.0.1]:35075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOGL7-0003SW-JM for submit@debbugs.gnu.org; Fri, 12 Jan 2024 07:08:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOGL5-0003SJ-Ei for 68401@debbugs.gnu.org; Fri, 12 Jan 2024 07:08:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOGL0-0007K5-7N; Fri, 12 Jan 2024 07:08:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=y0YCLd1j8/M1hZyLGJQqk9v11/EHfyiJpKK+pS7TlWI=; b=qvclRgQaoy4y 5qH/RdQAovEVnhthDVH0fO8qzcYN10A6t/3WrUTrFLL2oh+36qNaToYIqvYQdOjDnJKrXQaIYvw0m LrUDj7ozjKWV71KBj2Dex+h7s3NmpqFOEm/89vGFn5AXWjrEKuAeFMlroUB/WXUeDv4cTg0l0qDRl V3TyqG+EqkgKGoPSOOgO5MCFbg/SGQUGOk9aUPfQs4xVNN42nyH//RelNRKzPOK5IQJ3hKropnfuN Zfdi6NdCAoWEohAwHcBVXJCRk0SISWCv6hk910gLzeXy0idgFx+7QPnult9xdkxKmlehU45B4FPN1 Z9iI0yFT0a4u98q59Pvn0w==; In-Reply-To: <87v87yvnly.fsf@dataswamp.org> (message from Emanuel Berg on Fri, 12 Jan 2024 11:43:05 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278015 Archived-At: > Cc: emacs-erc@gnu.org > From: Emanuel Berg > Tags: patch > Date: Fri, 12 Jan 2024 11:43:05 +0100 > > Patch without whitespace changes. It still lacks a log message according to our conventions. > >From a2345b8eb22af2d5a052c1e22a19aeffc48544b2 Mon Sep 17 00:00:00 2001 > From: Emanuel Berg > Date: Fri, 12 Jan 2024 11:37:28 +0100 > Subject: [PATCH] `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. This only gives the header line of a commit log message, but the "meat" is missing. Here's a random example of a valid commit log message (you can see more by typing "git log" from the shell prompt or "C-x v L" inside Emacs): Implement missing functions for custom-icon widget * lisp/cus-edit.el (custom-icon-reset-saved, custom-icon-mark-to-save) (custom-icon-state-set-and-redraw, custom-icon-reset-standard) (custom-icon-mark-to-reset-standard): New functions. (custom-icon, custom-icon-extended-menu): Register and add them to the menu. (Bug#66947) See CONTRIBUTE for more information about our conventions in this regard. > -(defun erc-cmd-AMSG (line) > - "Send LINE to all channels of the current server that you are on." > - (interactive "sSend to all channels you're on: ") > +(defun erc-cmd-GMSG (line) > + "Send LINE to all channels on all networks you are on." > + (interactive "sSend to all channels: ") Our style is also to mention the interactive prompts in the doc string: "Send LINE to all channels on all networks you are on. Interactively, prompt for the line of text to send." > +(defun erc-cmd-AMSG (line) > + "Send LINE to all channels of the current network." Same here. > +(defun erc-cmd-GME (line) > + "Send LINE as an action to all channels on all networks you are on." And here. > +(defun erc-cmd-AME (line) > + "Send LINE as an action to all channels on the current network." And here. Thanks.