From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 6cd5678: Clarify compiler-pacifier in frame.c
Date: Tue, 27 Aug 2019 00:28:58 -0700 [thread overview]
Message-ID: <834b9308-5235-be47-1cf8-136bb6f35e48@cs.ucla.edu> (raw)
In-Reply-To: <831rx7f863.fsf@gnu.org>
Eli Zaretskii wrote:
> I think you didn't read the code of XParseGeometry (the one that is
> executed on MS-Windows) well enough, if you think GCC gave a false
> alarm.
I just now reread that code in current master and still see only a false alarm.
If that function returns a mask where (mask & XValue) != 0, then *x must have
been set by this statement:
5298 if (mask & XValue)
5299 *x = clip_to_bounds (INT_MIN, tempX, INT_MAX);
So, if GCC warns about the use of x in the calling code:
5342 int geometry = XParseGeometry (SSDATA (string),
5343 &x, &y, &width, &height);
5344 Lisp_Object result = Qnil;
5345 if (geometry & XValue)
5346 {
5347 Lisp_Object element;
5348
5349 if (x >= 0 && (geometry & XNegative))
... then GCC is giving a false alarm: x must be initialized in line 5349 if
(geometry & XValue) is nonzero in line 5345.
If my reasoning is wrong, can you give the path through the function and its
caller where x is used as an uninitialized variable? Because if there is such a
path, we shouldn't be marking x with UNINIT; UNINIT is only for pacifying false
alarms.
Similarly for y.
next prev parent reply other threads:[~2019-08-27 7:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 6:14 [Emacs-diffs] master 6cd5678: Clarify compiler-pacifier in frame.c Eli Zaretskii
2019-08-25 0:52 ` Paul Eggert
2019-08-25 7:13 ` Eli Zaretskii
2019-08-26 6:34 ` Paul Eggert
2019-08-26 7:54 ` Eli Zaretskii
2019-08-26 8:15 ` Paul Eggert
2019-08-26 9:47 ` Eli Zaretskii
2019-08-26 15:21 ` Óscar Fuentes
2019-08-26 16:13 ` Eli Zaretskii
2019-08-26 18:20 ` Óscar Fuentes
2019-08-26 18:39 ` Eli Zaretskii
2019-08-26 19:09 ` Paul Eggert
2019-08-26 19:15 ` Óscar Fuentes
2019-08-26 19:33 ` Eli Zaretskii
2019-08-26 19:49 ` Óscar Fuentes
2019-08-26 22:33 ` Paul Eggert
2019-08-27 6:12 ` Eli Zaretskii
2019-08-27 7:28 ` Paul Eggert [this message]
2019-08-27 8:02 ` Eli Zaretskii
2019-08-27 9:28 ` Paul Eggert
2019-08-27 10:15 ` Eli Zaretskii
2019-08-27 12:05 ` Paul Eggert
2019-08-27 12:43 ` Eli Zaretskii
2019-08-26 18:50 ` Paul Eggert
2019-08-26 18:56 ` Eli Zaretskii
2019-08-26 23:17 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834b9308-5235-be47-1cf8-136bb6f35e48@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.