* bug#5813: remove __DJGPP__ version tests @ 2010-03-31 19:33 Dan Nicolaescu 2010-04-01 15:37 ` Eli Zaretskii 0 siblings, 1 reply; 5+ messages in thread From: Dan Nicolaescu @ 2010-03-31 19:33 UTC (permalink / raw) To: 5813 Are the __DJGPP__ version tests still needed? Can we assume __DJGPP__ >= 2 is true? Any reason not to remove them? ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#5813: remove __DJGPP__ version tests 2010-03-31 19:33 bug#5813: remove __DJGPP__ version tests Dan Nicolaescu @ 2010-04-01 15:37 ` Eli Zaretskii [not found] ` <yxqwrwqn498.fsf@fencepost.gnu.org> 0 siblings, 1 reply; 5+ messages in thread From: Eli Zaretskii @ 2010-04-01 15:37 UTC (permalink / raw) To: Dan Nicolaescu; +Cc: 5813-done > From: Dan Nicolaescu <dann@gnu.org> > Date: Wed, 31 Mar 2010 15:33:03 -0400 > > Are the __DJGPP__ version tests still needed? > Can we assume __DJGPP__ >= 2 is true? > > Any reason not to remove them? Yes, it's time to forget about DJGPP < 2. Thanks for pointing this out. I removed all the tests for __DJGPP__. There are still 3 tests for __DJGPP_MINOR__, but they are in MSDOS-specific files (dosfns.c and msdos.c). I also updated CPP-DEFINES accordingly. ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <yxqwrwqn498.fsf@fencepost.gnu.org>]
* Re: bug#5813: remove __DJGPP__ version tests [not found] ` <yxqwrwqn498.fsf@fencepost.gnu.org> @ 2010-04-02 7:44 ` Eli Zaretskii 2010-04-02 8:35 ` Dan Nicolaescu 0 siblings, 1 reply; 5+ messages in thread From: Eli Zaretskii @ 2010-04-02 7:44 UTC (permalink / raw) To: Dan Nicolaescu; +Cc: emacs-devel > Cc: 5813-done@debbugs.gnu.org > From: Dan Nicolaescu <dann@gnu.org> > Date: Thu, 01 Apr 2010 19:26:43 -0400 > > Can you please also remove comments like: > /* Demacs 1.1.1 91/10/16 HIRANO Satoshi */ > that have about zero use now. Sorry, no. Not unless we are removing all the other "personalized" comments, of which we have quite a few. Some examples: /* Rewritten for clarity and GC protection by rms in Feb 94. */ /* There is no way to specify the before_dot and after_dot operators. rms says this is ok. --karl */ /* rms, 2003-01-03: I think I have fixed this bug. */ Personally, I don't like to remove other people's credit, even when expressed in this form. But if we are going to delete all such comments, I won't object. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: bug#5813: remove __DJGPP__ version tests 2010-04-02 7:44 ` Eli Zaretskii @ 2010-04-02 8:35 ` Dan Nicolaescu 2010-04-02 8:57 ` Eli Zaretskii 0 siblings, 1 reply; 5+ messages in thread From: Dan Nicolaescu @ 2010-04-02 8:35 UTC (permalink / raw) To: Eli Zaretskii; +Cc: emacs-devel Eli Zaretskii <eliz@gnu.org> writes: >> Cc: 5813-done@debbugs.gnu.org >> From: Dan Nicolaescu <dann@gnu.org> >> Date: Thu, 01 Apr 2010 19:26:43 -0400 >> >> Can you please also remove comments like: >> /* Demacs 1.1.1 91/10/16 HIRANO Satoshi */ >> that have about zero use now. > > Sorry, no. Not unless we are removing all the other "personalized" > comments, of which we have quite a few. Some examples: > > /* Rewritten for clarity and GC protection by rms in Feb 94. */ > > /* There is no way to specify the before_dot and after_dot > operators. rms says this is ok. --karl */ > > /* rms, 2003-01-03: I think I have fixed this bug. */ > > Personally, I don't like to remove other people's credit, even when > expressed in this form. But if we are going to delete all such > comments, I won't object. IMHO as long as the personalized comments have some useful information. /* Demacs 1.1.1 91/10/16 HIRANO Satoshi */ is kind of content free. [I run into those by chance when searching for -Demacs...] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: bug#5813: remove __DJGPP__ version tests 2010-04-02 8:35 ` Dan Nicolaescu @ 2010-04-02 8:57 ` Eli Zaretskii 0 siblings, 0 replies; 5+ messages in thread From: Eli Zaretskii @ 2010-04-02 8:57 UTC (permalink / raw) To: Dan Nicolaescu; +Cc: emacs-devel > Cc: emacs-devel@gnu.org > From: Dan Nicolaescu <dann@gnu.org> > Date: Fri, 02 Apr 2010 04:35:50 -0400 > > Eli Zaretskii <eliz@gnu.org> writes: > > >> Cc: 5813-done@debbugs.gnu.org > >> From: Dan Nicolaescu <dann@gnu.org> > >> Date: Thu, 01 Apr 2010 19:26:43 -0400 > >> > >> Can you please also remove comments like: > >> /* Demacs 1.1.1 91/10/16 HIRANO Satoshi */ > >> that have about zero use now. > > > > Sorry, no. Not unless we are removing all the other "personalized" > > comments, of which we have quite a few. Some examples: > > > > /* Rewritten for clarity and GC protection by rms in Feb 94. */ > > > > /* There is no way to specify the before_dot and after_dot > > operators. rms says this is ok. --karl */ > > > > /* rms, 2003-01-03: I think I have fixed this bug. */ > > > > Personally, I don't like to remove other people's credit, even when > > expressed in this form. But if we are going to delete all such > > comments, I won't object. > > IMHO as long as the personalized comments have some useful information. > /* Demacs 1.1.1 91/10/16 HIRANO Satoshi */ is kind of content free. Stefan and Yidong, it's your call. I'll go along with any decision you make. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-04-02 8:57 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-03-31 19:33 bug#5813: remove __DJGPP__ version tests Dan Nicolaescu 2010-04-01 15:37 ` Eli Zaretskii [not found] ` <yxqwrwqn498.fsf@fencepost.gnu.org> 2010-04-02 7:44 ` Eli Zaretskii 2010-04-02 8:35 ` Dan Nicolaescu 2010-04-02 8:57 ` Eli Zaretskii
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.