building error of latest emacs on Windowxp

building error of latest emacs on Windowxp

[zwz]

I checked out the latest emacs today, and some error came up during
"make bootstrap":

make[1]: entering directory `/d/git/emacs/lib-src'
mkdir "oo-spd"
mkdir "oo-spd/i386"
echo oo-spd/i386 > stamp_BLD
echo config.nt has changed. Re-run configure.bat.
config.nt has changed. Re-run configure.bat.
exit -1
make[1]: *** [../src/config.h] Error 255
make[1]: leaving directory `/d/git/emacs/lib-src'
make[1]: *** [bootstrap-gmake] Error 2

Of course I have run configure.bat before I run make bootstrap.

Re: building error of latest emacs on Windowxp

[Juanma Barranquero]

On Tue, Sep 28, 2010 at 12:26, zwz <zhangweize@gmail.com> wrote:

> I checked out the latest emacs today, and some error came up during
> "make bootstrap":

It could be some change of mine, but I don't have time to check right
now. Please revert revnos 101656, 101649 and see whether that helps.
I'll try to find the cause tonight.

    Juanma

Re: building error of latest emacs on Windowxp

[Eli Zaretskii]

> From: zwz <zhangweize@gmail.com>
> Date: Tue, 28 Sep 2010 18:26:17 +0800
> 
> I checked out the latest emacs today, and some error came up during
> "make bootstrap":
> 
> make[1]: entering directory `/d/git/emacs/lib-src'
> mkdir "oo-spd"
> mkdir "oo-spd/i386"
> echo oo-spd/i386 > stamp_BLD
> echo config.nt has changed. Re-run configure.bat.
> config.nt has changed. Re-run configure.bat.
> exit -1

Is the file nt/config.nt newer than src/config.h?

If so, there's some bug in nt/configure.bat.  Near its end, it tries
to determine whether src/config.h needs to be updated (because
overwriting it will trigger recompilation of all the sources).  Here
is the portion of the script which does that:

  Rem See if fc.exe returns a meaningful exit status.  If it does, we
  Rem might as well avoid unnecessary overwriting of config.h and epaths.h,
  Rem since this forces recompilation of every source file.
  if exist foo.bar del foo.bar
  fc /b foo.bar foo.bar >nul 2>&1
  if not errorlevel 2 goto doCopy
  fc /b config.tmp ..\src\config.h >nul 2>&1
  if errorlevel 1 goto doCopy
  fc /b paths.h ..\src\epaths.h >nul 2>&1
  if errorlevel 0 goto dontCopy

  :doCopy
  copy config.tmp ..\src\config.h
  copy paths.h ..\src\epaths.h

  :dontCopy
  if exist config.tmp del config.tmp

Could you please investigate why this logic fails in your case, and
post the results here?

TIA

Re: building error of latest emacs on Windowxp

[zwz]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: zwz <zhangweize@gmail.com>
>> Date: Tue, 28 Sep 2010 18:26:17 +0800
>> 
>> I checked out the latest emacs today, and some error came up during
>> "make bootstrap":
>> 
>> make[1]: entering directory `/d/git/emacs/lib-src'
>> mkdir "oo-spd"
>> mkdir "oo-spd/i386"
>> echo oo-spd/i386 > stamp_BLD
>> echo config.nt has changed. Re-run configure.bat.
>> config.nt has changed. Re-run configure.bat.
>> exit -1
>
> Is the file nt/config.nt newer than src/config.h?
Yes, nt/config.nt is much newer than src/config.h.

>
> If so, there's some bug in nt/configure.bat.  Near its end, it tries
> to determine whether src/config.h needs to be updated (because
> overwriting it will trigger recompilation of all the sources).  Here
> is the portion of the script which does that:

I create a new nt/test.bat with the portion of the script.
The output suggests that the logic jumps to doCopy
after running to "if errorlevel 1 goto doCopy".

Hope this helps.
>
>   Rem See if fc.exe returns a meaningful exit status.  If it does, we
>   Rem might as well avoid unnecessary overwriting of config.h and
> epaths.h,
>   Rem since this forces recompilation of every source file.
>   if exist foo.bar del foo.bar
>   fc /b foo.bar foo.bar >nul 2>&1
>   if not errorlevel 2 goto doCopy
>   fc /b config.tmp ..\src\config.h >nul 2>&1
>   if errorlevel 1 goto doCopy
>   fc /b paths.h ..\src\epaths.h >nul 2>&1
>   if errorlevel 0 goto dontCopy
>
>   :doCopy
>   copy config.tmp ..\src\config.h
>   copy paths.h ..\src\epaths.h
>
>   :dontCopy
>   if exist config.tmp del config.tmp
>
> Could you please investigate why this logic fails in your case, and
> post the results here?
>
> TIA

Re: building error of latest emacs on Windowxp

[Eli Zaretskii]

> From: zwz <zhangweize@gmail.com>
> Date: Wed, 29 Sep 2010 16:42:24 +0800
> 
> I create a new nt/test.bat with the portion of the script.
> The output suggests that the logic jumps to doCopy
> after running to "if errorlevel 1 goto doCopy".

Thanks.  So if you now re-run configure.bat a second time, does the
problem go away?  That is, are you able to run "make" cleanly after
re-running configure.bat?

Re: building error of latest emacs on Windowxp

[zwz]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: zwz <zhangweize@gmail.com>
>> Date: Wed, 29 Sep 2010 16:42:24 +0800
>> 
>> I create a new nt/test.bat with the portion of the script.
>> The output suggests that the logic jumps to doCopy
>> after running to "if errorlevel 1 goto doCopy".
>
> Thanks.  So if you now re-run configure.bat a second time, does the
> problem go away?  That is, are you able to run "make" cleanly after
> re-running configure.bat?
No. The same error.
The src/config.h seems not updated at all.
I guess there may be no config.tmp during configure.

Re: building error of latest emacs on Windowxp

[Juanma Barranquero]

On Wed, Sep 29, 2010 at 12:22, zwz <zhangweize@gmail.com> wrote:

> The src/config.h seems not updated at all.
> I guess there may be no config.tmp during configure.

Try stopping configure.bat just as it enters doCopy and see whether
config.tmp exists and looks correct.

    Juanma

Re: building error of latest emacs on Windowxp

[grischka]

> Try stopping configure.bat just as it enters doCopy and see whether
> config.tmp exists and looks correct.

Try "touch nt/config.nt" to reproduce the bug ;)

Re: building error of latest emacs on Windowxp

[Eli Zaretskii]

> From: zwz <zhangweize@gmail.com>
> Date: Wed, 29 Sep 2010 18:22:25 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: zwz <zhangweize@gmail.com>
> >> Date: Wed, 29 Sep 2010 16:42:24 +0800
> >> 
> >> I create a new nt/test.bat with the portion of the script.
> >> The output suggests that the logic jumps to doCopy
> >> after running to "if errorlevel 1 goto doCopy".
> >
> > Thanks.  So if you now re-run configure.bat a second time, does the
> > problem go away?  That is, are you able to run "make" cleanly after
> > re-running configure.bat?
> No. The same error.
> The src/config.h seems not updated at all.
> I guess there may be no config.tmp during configure.

How can that happen?  The following lines from configure.bat
unconditionally create it from config.nt and add 2 lines to it:

    copy config.nt config.tmp
    echo. >>config.tmp
    echo /* Start of settings from configure.bat.  */ >>config.tmp

And even if config.tmp were indeed missing, the `fc' command that is
run by configure.bat, viz.:

    fc /b config.tmp ..\src\config.h >nul 2>&1
    if errorlevel 1 goto doCopy

should have forced the branch to doCopy, because `fc' exits with
status of 2 if one of its file arguments does not exist.  Then the
copy command:

    :doCopy
    copy config.tmp ..\src\config.h

should have complained like this:

    The system cannot find the file specified.

if config.tmp did not exist.  Do you see such an error message when
configure.bat runs?

Hmm... I think I see the problem.  The second line of this
fragment:

    fc /b paths.h ..\src\epaths.h >nul 2>&1
    if errorlevel 0 goto dontCopy

should say instead

    if not errorlevel 1 goto dontCopy

Could you try this change, please?

Re: building error of latest emacs on Windowxp

[Eli Zaretskii]

> Date: Wed, 29 Sep 2010 14:42:55 +0200
> From: grischka <grishka@gmx.de>
> Cc: emacs-devel@gnu.org
> 
> > Try stopping configure.bat just as it enters doCopy and see whether
> > config.tmp exists and looks correct.
> 
> Try "touch nt/config.nt" to reproduce the bug ;)

Try not to shooting yourself in the foot.

Re: building error of latest emacs on Windowxp

[Eli Zaretskii]

> From: zwz <zhangweize@gmail.com>
> Date: Wed, 29 Sep 2010 16:42:24 +0800
> 
> > Is the file nt/config.nt newer than src/config.h?
> Yes, nt/config.nt is much newer than src/config.h.

What is the date of nt/config.nt?

The last change in that file was on Aug 2.  If you updated your tree
more than once since then, there could be some other factor at work
here.  Perhaps you somehow changed the time stamp of nt/config.nt
without changing its contents, by some command you ran locally.  In
that case, simply remove src/config.h and re-run configure.bat.

Re: building error of latest emacs on Windowxp

[Juanma Barranquero]

On Wed, Sep 29, 2010 at 15:18, Eli Zaretskii <eliz@gnu.org> wrote:

> Perhaps you somehow changed the time stamp of nt/config.nt
> without changing its contents, by some command you ran locally.  In
> that case, simply remove src/config.h and re-run configure.bat.

But, why should it be necessary to remove src/config.h by hand?

  cd nt
  touch config.nt
  make all
      => config.nt has changed.  Re-run configure.bat
  configure.bat   // with suitable arguments
  make all
      => config.nt has changed.  Re-run configure.bat

Uh?

What's even more funny, if you do

  cd nt
  touch config.nt
  make all
      => config.nt has changed.  Re-run configure.bat
  configure.bat   // forgetting --cflags -I for the image libraries
      => Important libraries are missing. Fix these issues before running make.
  make all

and it tries to build.

So, it seems like either lib-src/makefile.w32-in should delete
src/config.h, or if that's too dangerous (though I don't see why), at
the very least give a more informative message...

    Juanma

Re: building error of latest emacs on Windowxp

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Wed, 29 Sep 2010 15:45:07 +0200
> Cc: zwz <zhangweize@gmail.com>, emacs-devel@gnu.org
> 
> So, it seems like either lib-src/makefile.w32-in should delete
> src/config.h, or if that's too dangerous (though I don't see why), at
> the very least give a more informative message...

I think removing src/config.h is fine in this case.  It is outdated
anyway.

Re: building error of latest emacs on Windowxp

[zwz]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: zwz <zhangweize@gmail.com>
>> Date: Wed, 29 Sep 2010 16:42:24 +0800
>> 
>> > Is the file nt/config.nt newer than src/config.h?
>> Yes, nt/config.nt is much newer than src/config.h.
>
> What is the date of nt/config.nt?
>
> The last change in that file was on Aug 2.  If you updated your tree
> more than once since then, there could be some other factor at work
> here.  Perhaps you somehow changed the time stamp of nt/config.nt
> without changing its contents, by some command you ran locally.  In
> that case, simply remove src/config.h and re-run configure.bat.

I just remove the src/config.h by hand, re-run configure.bat (which
generates a new src/config.h), and then there is no error during make.

Re: building error of latest emacs on Windowxp

[Juanma Barranquero]

On Wed, Sep 29, 2010 at 15:50, Eli Zaretskii <eliz@gnu.org> wrote:

> I think removing src/config.h is fine in this case.  It is outdated
> anyway.

Done.

    Juanma

Re: building error of latest emacs on Windowxp

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Wed, 29 Sep 2010 17:35:49 +0200
> Cc: zhangweize@gmail.com, emacs-devel@gnu.org
> 
> On Wed, Sep 29, 2010 at 15:50, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> > I think removing src/config.h is fine in this case.  It is outdated
> > anyway.
> 
> Done.

Thanks.