From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 8435@debbugs.gnu.org
Subject: bug#8435: misuse of error ("...%d...", ...) on 64-bit hosts
Date: Thu, 07 Apr 2011 21:31:55 +0300 [thread overview]
Message-ID: <8339ltvrok.fsf@gnu.org> (raw)
In-Reply-To: <4D9D68D8.6060200@cs.ucla.edu>
> Date: Thu, 07 Apr 2011 00:33:44 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
>
> This patch assumes that vsnprintf works.
Bother: using `vsnprintf' here could cause problems when `error' is
used to format messages with non-ASCII characters. `doprnt' was
careful in these cases, e.g., it would take care of truncating
multibyte strings only on character boundaries. It also supported %c
format for converting a multibyte character to its integer
representation. Can we trust `vsnprintf' to not misbehave in these
cases, and DTRT with the entire repertory of characters supported by
Emacs?
There's also an issue with old pre-C99 implementations of `vsnprintf'
which returned -1 when the buffer was too small. However, I think
catering for those would be a trivial change in `verror', so that's
not a big deal.
> I assume that vsnprintf works on Windows, so the presence or absence
> of the vsnprintf module shouldn't matter for Windows.
Yes, the MinGW build will have no problem. The MSVC build will need
the above-mentioned change in `verror', because the Microsoft
runtime's version of `vsnprintf' is not compatible with ISO C99. But
that can be fixed later, if needed.
next prev parent reply other threads:[~2011-04-07 18:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 19:59 bug#8435: misuse of error ("...%d...", ...) on 64-bit hosts Paul Eggert
[not found] ` <handler.8435.B.130211997010029.ack@debbugs.gnu.org>
2011-04-07 7:33 ` Paul Eggert
2011-04-07 12:29 ` Andy Moreton
2011-04-07 18:31 ` Eli Zaretskii [this message]
2011-04-07 20:43 ` Paul Eggert
2011-04-08 8:58 ` Eli Zaretskii
2011-04-08 23:34 ` Paul Eggert
2011-04-09 7:20 ` Eli Zaretskii
2011-04-09 18:24 ` Paul Eggert
2011-04-09 18:32 ` Eli Zaretskii
2011-04-09 19:39 ` Paul Eggert
2011-04-09 20:21 ` Eli Zaretskii
2011-04-10 3:52 ` Stefan Monnier
2011-04-10 5:19 ` Eli Zaretskii
2011-04-11 1:44 ` Stefan Monnier
2011-04-11 2:54 ` Eli Zaretskii
2011-04-10 17:03 ` Paul Eggert
2011-04-09 19:28 ` Eli Zaretskii
2011-04-09 19:43 ` Paul Eggert
2011-04-08 23:37 ` Paul Eggert
2011-04-25 0:59 ` Daniel Colascione
2011-04-25 6:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8339ltvrok.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=8435@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.