From: Eli Zaretskii <eliz@gnu.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: emacs-devel@gnu.org
Subject: Re: Truncating scroll runs that copy to where we copied to
Date: Sun, 20 Nov 2011 20:23:27 +0200 [thread overview]
Message-ID: <8339dibqlc.fsf@gnu.org> (raw)
In-Reply-To: <wlty5ztgeg.wl%mituharu@math.s.chiba-u.ac.jp>
> Date: Sun, 20 Nov 2011 16:13:59 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
>
> I think that `scrolling_window' needs to truncate scroll runs that
> copy to where we copied to; otherwise, `assign_row (to, from)' assigns
> a previously disabled bogus row in the desired matrix when we have an
> overlap in the copy destination. Such truncation can also avoid
> unnecessary copy in the actual graphics operation.
>
> Could someone double-check the code below?
Could you please elaborate on the rationale? Like, give a specific
use case with a few rows in the current and desired matrix, and show
why the current code does not DTRT?
I'm not saying you are wrong (I have my doubts about portions of that
function), just that we should at least look into a specific test
case, even if simplified one, to make sure we are fixing a real bug.
TIA
next prev parent reply other threads:[~2011-11-20 18:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 7:13 Truncating scroll runs that copy to where we copied to YAMAMOTO Mitsuharu
2011-11-20 18:23 ` Eli Zaretskii [this message]
2011-11-21 0:19 ` YAMAMOTO Mitsuharu
2011-11-21 23:50 ` David Reitter
2011-11-22 6:04 ` Eli Zaretskii
2011-11-22 6:22 ` YAMAMOTO Mitsuharu
2011-11-22 8:25 ` Eli Zaretskii
2011-11-22 8:47 ` YAMAMOTO Mitsuharu
2011-11-22 7:26 ` YAMAMOTO Mitsuharu
2011-11-22 8:52 ` Eli Zaretskii
2011-11-22 9:09 ` YAMAMOTO Mitsuharu
2011-11-22 9:54 ` Eli Zaretskii
2011-11-23 0:41 ` YAMAMOTO Mitsuharu
2011-11-26 12:44 ` Eli Zaretskii
2011-11-28 1:10 ` YAMAMOTO Mitsuharu
2011-11-22 0:33 ` YAMAMOTO Mitsuharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8339dibqlc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.