From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 9/9] Detect window-system from display name Date: Wed, 08 Aug 2012 19:50:23 +0300 Message-ID: <83393xfhv4.fsf@gnu.org> References: <94f53f9a4d2d8ebe852360652eeee429520f3d9f.1344326992.git.dancol@dancol.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1344444629 12326 80.91.229.3 (8 Aug 2012 16:50:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 8 Aug 2012 16:50:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 08 18:50:29 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sz9Sl-000394-Pa for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2012 18:50:27 +0200 Original-Received: from localhost ([::1]:48969 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz9Sl-0006zB-2p for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2012 12:50:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz9Si-0006z6-Nc for emacs-devel@gnu.org; Wed, 08 Aug 2012 12:50:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sz9Sh-0000NV-NC for emacs-devel@gnu.org; Wed, 08 Aug 2012 12:50:24 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:49654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz9Sh-0000NN-Ew for emacs-devel@gnu.org; Wed, 08 Aug 2012 12:50:23 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M8G00B0042CVX00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Wed, 08 Aug 2012 19:50:21 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M8G00B5P43WW400@a-mtaout22.012.net.il>; Wed, 08 Aug 2012 19:50:21 +0300 (IDT) In-reply-to: <94f53f9a4d2d8ebe852360652eeee429520f3d9f.1344326992.git.dancol@dancol.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152343 Archived-At: > Date: Tue, 07 Aug 2012 01:19:27 -0700 > From: Daniel Colascione > > +(add-to-list 'display-format-alist '("\\`windows\\'" . w32)) Is this kind of addition needed only for make-frame-on-display, or is it used for other functions as well? > + CHECK_STRING (display); > + if (strcmp (SSDATA (display), "windows")) > + error ("The name of the Windows display must be \"windows\""); Why signal an error here? In any case, please use 'strcmp (...) != 0' here. I think the bulk of this changeset should be reviewed by someone else, as it has very little to do with Windows.