From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109864: Fix minor problems found by static checking. Date: Mon, 03 Sep 2012 18:35:01 +0300 Message-ID: <83392zf7bu.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1346686515 19474 80.91.229.3 (3 Sep 2012 15:35:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Sep 2012 15:35:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 03 17:35:17 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T8YgA-000478-D0 for ged-emacs-devel@m.gmane.org; Mon, 03 Sep 2012 17:35:10 +0200 Original-Received: from localhost ([::1]:39179 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8Yg7-0007in-DA for ged-emacs-devel@m.gmane.org; Mon, 03 Sep 2012 11:35:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8Yfx-0007Hr-JW for emacs-devel@gnu.org; Mon, 03 Sep 2012 11:34:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T8Yfw-0003sT-MP for emacs-devel@gnu.org; Mon, 03 Sep 2012 11:34:57 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:64101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T8Yfw-0003sL-Dy for emacs-devel@gnu.org; Mon, 03 Sep 2012 11:34:56 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M9S00C005XTN300@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Mon, 03 Sep 2012 18:34:54 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M9S00CHB5Y5CW40@a-mtaout20.012.net.il>; Mon, 03 Sep 2012 18:34:54 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152966 Archived-At: > --- a/src/doc.c 2012-09-02 16:56:31 +0000 > +++ b/src/doc.c 2012-09-03 09:22:43 +0000 > @@ -848,9 +848,10 @@ > struct buffer *oldbuf; > ptrdiff_t start_idx; > /* This is for computing the SHADOWS arg for describe_map_tree. */ > - Lisp_Object active_maps = Fcurrent_active_maps (Qnil, Qnil); > + Lisp_Object active_maps; > Lisp_Object earlier_maps; > > + active_maps = Fcurrent_active_maps (Qnil, Qnil); > changed = 1; > strp += 2; /* skip \{ or \< */ > start = strp; What problems did static checking find in this (and other similar) fragment?