From: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org
Subject: Missing dependencies in lib-src/Makefile.in
Date: Sat, 06 Apr 2013 15:34:08 +0300 [thread overview]
Message-ID: <8338v3et33.fsf@gnu.org> (raw)
Since lib-src/Makefile.in doesn't use the automatic dependencies, all
the prerequisite header files should be spelled out explicitly, I
think, or else we will have subtle bugs. But I don't see the required
dependencies in some cases.
Specifically, many sources include standard headers that are replaced
by gnulib in ../lib. However, there are no prerequisite ../lib/*.h
files in lib-src/Makefile.in, with a single exception of min-max.h for
pop.o (ebrowse.c also includes min-max.h, but does not have it as a
prerequisite).
In most cases, we should probably be safe, because all the executables
are produced by compiling their *.c files, and have ../lib/libgnu.a as
their prerequisite. So any change in lib is likely to trigger
recompilation because libgnu.a will be rebuilt.
But there are exceptions: pop.o and regex.o. AFAICS, they will not be
recompiled if some of the headers in lib/ are modified, because none
of their prerequisites depend directly or indirectly on gnulib
headers.
Am I missing something? If not, should this be fixed?
next reply other threads:[~2013-04-06 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 12:34 Eli Zaretskii [this message]
2013-04-06 20:27 ` Missing dependencies in lib-src/Makefile.in Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8338v3et33.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.