From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15880: Compute C declarations for DEFSYMs automatically. Date: Thu, 08 Jan 2015 15:28:03 +0200 Message-ID: <83387l7670.fsf@gnu.org> References: <5282C8F4.5010806@cs.ucla.edu> <5494D719.4040507@cs.ucla.edu> <5499FFF1.9050106@cs.ucla.edu> <54AAC905.1020906@cs.ucla.edu> <54AAD51C.7020207@cs.ucla.edu> <83lhlh83a3.fsf@gnu.org> <54AAE504.5090701@cs.ucla.edu> <83egr980v9.fsf@gnu.org> <54AB0E11.5050908@cs.ucla.edu> <837fx08u67.fsf@gnu.org> <54ADDA79.3050105@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1420724016 8319 80.91.229.3 (8 Jan 2015 13:33:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 8 Jan 2015 13:33:36 +0000 (UTC) Cc: 15880@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 08 14:33:30 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y9D8G-0000ho-VD for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Jan 2015 14:28:13 +0100 Original-Received: from localhost ([::1]:46047 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9D8G-0004Ul-10 for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Jan 2015 08:28:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9D8B-0004Ro-DB for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2015 08:28:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9D87-0008UJ-8e for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2015 08:28:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9D87-0008UF-5g for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2015 08:28:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y9D86-0006Wn-D4 for bug-gnu-emacs@gnu.org; Thu, 08 Jan 2015 08:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jan 2015 13:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15880 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 15880-submit@debbugs.gnu.org id=B15880.142072367425079 (code B ref 15880); Thu, 08 Jan 2015 13:28:02 +0000 Original-Received: (at 15880) by debbugs.gnu.org; 8 Jan 2015 13:27:54 +0000 Original-Received: from localhost ([127.0.0.1]:39932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9D7x-0006WQ-H0 for submit@debbugs.gnu.org; Thu, 08 Jan 2015 08:27:53 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:55404) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9D7u-0006WH-NE for 15880@debbugs.gnu.org; Thu, 08 Jan 2015 08:27:51 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NHV00B001CG4Y00@a-mtaout20.012.net.il> for 15880@debbugs.gnu.org; Thu, 08 Jan 2015 15:27:49 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NHV00A961ECX070@a-mtaout20.012.net.il>; Thu, 08 Jan 2015 15:27:48 +0200 (IST) In-reply-to: <54ADDA79.3050105@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98112 Archived-At: > Date: Wed, 07 Jan 2015 17:16:41 -0800 > From: Paul Eggert > > Glenn Morris wrote: > > > > This change causes `make check' to fail; specifically in file-notify-tests. > > Thanks for reporting that bug. I reproduced the problem and installed the > attached patch, which fixes it for me. > > >From d71659fed4eb87eb3edbf8f83fb0e9ed2633fa74 Mon Sep 17 00:00:00 2001 > From: Paul Eggert > Date: Wed, 7 Jan 2015 17:12:16 -0800 > Subject: [PATCH] Port GFileMonitor * hack to Qnil==0 platforms > > Reported by Glenn Morris in: http://bugs.gnu.org/15880#112 > * gfilenotify.c (monitor_to_lisp, lisp_to_monitor): New functions. > (dir_monitor_callback, Fgfile_add_watch, Fgfile_rm_watch): Use them. > --- > src/ChangeLog | 7 +++++++ > src/gfilenotify.c | 33 +++++++++++++++++++++++---------- > 2 files changed, 30 insertions(+), 10 deletions(-) > > diff --git a/src/ChangeLog b/src/ChangeLog > index 8680c5e..2fc3479 100644 > --- a/src/ChangeLog > +++ b/src/ChangeLog > @@ -1,3 +1,10 @@ > +2015-01-08 Paul Eggert > + > + Port GFileMonitor * hack to Qnil==0 platforms > + Reported by Glenn Morris in: http://bugs.gnu.org/15880#112 > + * gfilenotify.c (monitor_to_lisp, lisp_to_monitor): New functions. > + (dir_monitor_callback, Fgfile_add_watch, Fgfile_rm_watch): Use them. Could we instead just keep the previous semantics of XIL and XLI, please? They are used in a few places outside lisp.h, so now all of those places need to be audited and most probably changed. Why isn't it better to change the implementation of just 2 macros instead?