From: Eli Zaretskii <eliz@gnu.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: 20410@debbugs.gnu.org
Subject: bug#20410: 24.5.50; cursor not updated after yank of non-ASCII string from the clipboard
Date: Sun, 26 Apr 2015 18:04:56 +0300 [thread overview]
Message-ID: <83383nx753.fsf@gnu.org> (raw)
In-Reply-To: <wlpp6r9pia.wl%mituharu@math.s.chiba-u.ac.jp>
> Date: Sun, 26 Apr 2015 19:02:05 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> Cc: 20410@debbugs.gnu.org
>
> > Does the patch below fix the problems you see? (It might look a bit
> > drastic, but then loading new fonts is not supposed to be a frequent
> > operation, I think.)
>
> Yes, it solves the problems as far as I tested. But because
> adjust_frame_glyphs are called from many places other than font
> changes, I wonder if it might disable some cases where some
> optimizations were applied successfully otherwise (sorry, I don't have
> any ideas about concrete examples). Some calls to adjust_frame_glyphs
> are already accompanied by SET_FRAME_GARBAGED, but not always.
Hmm... you are right, we could be more selective. Does the
alternative patch below work for you?
diff --git a/src/xdisp.c b/src/xdisp.c
index 5a27adc..cbe46eb 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -13359,6 +13359,13 @@ static void debug_method_add (struct window *, char const *, ...)
if (f->fonts_changed)
{
adjust_frame_glyphs (f);
+ /* Disable all redisplay optimizations for this frame.
+ This is because adjust_frame_glyphs resets the
+ enabled_p flag for all glyph rows of all windows, so
+ many optimizations will fail anyway, and some might
+ fail to test that flag and do bogus things as
+ result. */
+ SET_FRAME_GARBAGED (f);
f->fonts_changed = false;
}
/* If cursor type has been changed on the frame
@@ -13753,6 +13760,10 @@ static void debug_method_add (struct window *, char const *, ...)
if (f->fonts_changed)
{
adjust_frame_glyphs (f);
+ /* Disable all redisplay optimizations for this
+ frame. See the comment for the previous call
+ to adjust_frame_glyphs for the reasons. */
+ SET_FRAME_GARBAGED (f);
f->fonts_changed = false;
goto retry_frame;
}
next prev parent reply other threads:[~2015-04-26 15:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 9:59 bug#20410: 24.5.50; cursor not updated after yank of non-ASCII string from the clipboard YAMAMOTO Mitsuharu
2015-04-23 10:42 ` Eli Zaretskii
2015-04-24 4:09 ` YAMAMOTO Mitsuharu
2015-04-24 6:58 ` Eli Zaretskii
2015-04-25 9:49 ` YAMAMOTO Mitsuharu
2015-04-25 10:09 ` Eli Zaretskii
2015-04-25 12:32 ` Eli Zaretskii
2015-04-26 10:02 ` YAMAMOTO Mitsuharu
2015-04-26 15:04 ` Eli Zaretskii [this message]
2015-04-27 3:28 ` YAMAMOTO Mitsuharu
2015-04-27 15:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83383nx753.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20410@debbugs.gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.