From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20628: 25.0.50; Incorrect line height for some fonts Date: Sun, 24 May 2015 13:29:06 +0300 Message-ID: <83382m1d71.fsf@gnu.org> References: <20150522.234959.238191883.wl@gnu.org> <556189D0.2000208@live.com> <83bnha1fxw.fsf@gnu.org> <20150524.113203.250674550.wl@gnu.org> <83617i1f29.fsf@gnu.org> <834mn21e7y.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1432463435 19280 80.91.229.3 (24 May 2015 10:30:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 May 2015 10:30:35 +0000 (UTC) Cc: 20628@debbugs.gnu.org To: wl@gnu.org, clement.pitclaudel@live.com, ohwoeowho@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 24 12:30:24 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YwTAi-000096-F4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 May 2015 12:30:20 +0200 Original-Received: from localhost ([::1]:39640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwTAh-0003MR-Ki for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 May 2015 06:30:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwTAb-0003MB-75 for bug-gnu-emacs@gnu.org; Sun, 24 May 2015 06:30:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YwTAX-0002eL-BH for bug-gnu-emacs@gnu.org; Sun, 24 May 2015 06:30:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YwTAX-0002eG-7z for bug-gnu-emacs@gnu.org; Sun, 24 May 2015 06:30:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YwTAW-0000PM-38 for bug-gnu-emacs@gnu.org; Sun, 24 May 2015 06:30:08 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 May 2015 10:30:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20628-submit@debbugs.gnu.org id=B20628.14324633671452 (code B ref 20628); Sun, 24 May 2015 10:30:07 +0000 Original-Received: (at 20628) by debbugs.gnu.org; 24 May 2015 10:29:27 +0000 Original-Received: from localhost ([127.0.0.1]:54270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YwT9m-0000NF-N4 for submit@debbugs.gnu.org; Sun, 24 May 2015 06:29:26 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:33757) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YwT9h-0000Mm-3I for 20628@debbugs.gnu.org; Sun, 24 May 2015 06:29:21 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NOU00K00NPATX00@mtaout29.012.net.il> for 20628@debbugs.gnu.org; Sun, 24 May 2015 13:28:25 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NOU00IG1NRDBA20@mtaout29.012.net.il>; Sun, 24 May 2015 13:28:25 +0300 (IDT) In-reply-to: <834mn21e7y.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103134 Archived-At: > Date: Sun, 24 May 2015 13:06:57 +0300 > From: Eli Zaretskii > Cc: 20628@debbugs.gnu.org > > The relevant place in the display engine where these factors are taken > into consideration is around line 26388 in xdisp.c, which is part of > the function x_produce_glyphs. There you will find a call to the > function get_per_char_metric, which in turn calls the font driver's > text_extents method. The metrics returned by get_per_char_metric > include ascent and descent, but I think they are not in pixel units. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This part seems to be incorrect, as I see elsewhere in the code that phys_ascent and ascent are freely added and subtracted, and the same for phys_descent and descent. IOW, the per-character ascent/descent values are returned in pixel units. Sorry for any confusion I caused.