From: Eli Zaretskii <eliz@gnu.org>
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: emacs-devel@gnu.org
Subject: Re: fix/ert-multiline-explanation
Date: Mon, 26 Oct 2015 17:57:19 +0200 [thread overview]
Message-ID: <8337wxd3mo.fsf@gnu.org> (raw)
In-Reply-To: <87h9lehuvj.fsf@russet.org.uk>
> From: phillip.lord@russet.org.uk (Phillip Lord)
> Cc: <emacs-devel@gnu.org>
> Date: Mon, 26 Oct 2015 08:55:12 +0000
>
> F with
> (ert-test-failed
> ((should
> (silly-predicate
> (advice-add 'ert--pp-with-indentation-and-newline :around #'sisyphus--ert-pp-with-indentation-and-newline)))
> :form
> (silly-predicate nil)
> :value nil :explanation "Silly predicate is silly.
> I mean, it's in the name, so why are you using it?
> It's never going to return a sensible answer.
> It is after silly.
> ^^^^^"))
>
> F without
> (ert-test-failed
> ((should
> (silly-predicate
> (advice-remove 'ert--pp-with-indentation-and-newline #'sisyphus--ert-pp-with-indentation-and-newline)))
> :form
> (silly-predicate nil)
> :value nil :explanation "Silly predicate is silly.\nI mean, it's in the name, so why are you using it?\nIt's never going to return a sensible answer.\nIt is after silly.\n ^^^^^"))
Looks like your change is a clear improvement, so please install.
Thanks.
next prev parent reply other threads:[~2015-10-26 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 20:43 fix/ert-multiline-explanation Phillip Lord
2015-10-21 20:47 ` fix/ert-multiline-explanation David Kastrup
2015-10-22 8:44 ` fix/ert-multiline-explanation Phillip Lord
2015-10-23 9:02 ` fix/ert-multiline-explanation Phillip Lord
2015-10-24 14:45 ` fix/ert-multiline-explanation David Engster
2015-10-26 8:52 ` fix/ert-multiline-explanation Phillip Lord
2015-10-24 15:11 ` fix/ert-multiline-explanation Eli Zaretskii
2015-10-26 8:55 ` fix/ert-multiline-explanation Phillip Lord
2015-10-26 15:57 ` Eli Zaretskii [this message]
2015-10-27 12:46 ` fix/ert-multiline-explanation Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8337wxd3mo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=phillip.lord@russet.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.