From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 504696d: Etags: yet another improvement in Ruby tags
Date: Thu, 04 Feb 2016 05:48:07 +0200 [thread overview]
Message-ID: <8337t9xhjc.fsf@gnu.org> (raw)
In-Reply-To: <56B29165.3040404@yandex.ru> (message from Dmitry Gutov on Thu, 4 Feb 2016 02:46:45 +0300)
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 4 Feb 2016 02:46:45 +0300
>
> Just noticed this. attr_X calls will not, as a rule, be inside a method
> definition (which is what 'def X' is).
>
> If an attr_X call is inside a method definition, we're unlikely to be
> able to make much sense of it. Most likely, the arguments will be local
> variables, not Symbol literals. It's also likely that the target of this
> call in that kind of situation won't be the current class.
>
> Anyway, the example shouldn't put attr_X calls inside a method
> definition, or it gives an impression that we handle this situation
> intentionally, or somehow differently from the usual case. Whereas we
> could as well skip those tags altogether (but we don't really have to,
> as long as we only generate non-qualified tags, and check that every
> argument is a Symbol literal, i.e. it starts with a colon).
Please modify the test files as you see fit, and tell me what the tags
should be.
> > + alias_method :qux, :tee, attr_accessor :bogus
>
> This one is a bit weird as well:
>
> - An alias_method call with three arguments will raise an ArgumentError.
It's there to test the algorithm, which should not tag the bogus
accessor.
> - If it didn't, the 'attr_accessor :bogus' calls would raise a
> SyntaxError, due to evaluation rules. However, an attr_X call can be
> inside an expression, such as:
>
> class C
> puts(attr_accessor :bogus)
> end
>
> This is not a typical case, we don't need to handle it, but it's odd to
> see a test case that implies that this example is invalid, and we
> somehow prohibit it. Hopefully, this observation will allow you to
> simplify some code.
I'm not sure how this simplifies things. The point was that a comma
doesn't reset the mini-state machine to the state where it is once
again ready to see attr_accessor. If you are saying there are other
situations like that, please describe them.
IOW, does etags handle the above intentionally invalid code correctly?
It should.
Thanks.
next prev parent reply other threads:[~2016-02-04 3:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160203162536.2954.45438@vcs.savannah.gnu.org>
[not found] ` <E1aR0FM-0000mG-Up@vcs.savannah.gnu.org>
2016-02-03 23:46 ` [Emacs-diffs] emacs-25 504696d: Etags: yet another improvement in Ruby tags Dmitry Gutov
2016-02-04 3:48 ` Eli Zaretskii [this message]
2016-02-04 9:36 ` Dmitry Gutov
2016-02-04 17:28 ` Eli Zaretskii
2016-02-05 5:26 ` Dmitry Gutov
2016-02-05 5:29 ` Dmitry Gutov
2016-02-05 9:14 ` Eli Zaretskii
2016-02-05 10:11 ` Dmitry Gutov
2016-02-05 11:15 ` Eli Zaretskii
2016-02-05 11:26 ` Eli Zaretskii
2016-02-05 12:15 ` Dmitry Gutov
2016-02-05 14:34 ` Eli Zaretskii
2016-02-06 9:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8337t9xhjc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.