From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#5251: 23.1; problem in decode_eol of coding.c Date: Wed, 17 Feb 2016 17:53:41 +0200 Message-ID: <8337srwcxm.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1455724467 2573 80.91.229.3 (17 Feb 2016 15:54:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 17 Feb 2016 15:54:27 +0000 (UTC) Cc: t_tuneyosi@hotmail.com, 5251-done@debbugs.gnu.org To: Andrew Hyatt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 17 16:54:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aW4Qi-0004If-5P for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Feb 2016 16:54:16 +0100 Original-Received: from localhost ([::1]:58995 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW4Qh-0003sB-DK for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Feb 2016 10:54:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW4Qd-0003rx-SE for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 10:54:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW4QU-0006U1-F8 for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 10:54:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW4QU-0006Ts-Co for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 10:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aW4QU-0001dT-89 for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 10:54:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Feb 2016 15:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 5251 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 5251@debbugs.gnu.org, eliz@gnu.org, t_tuneyosi@hotmail.com Original-Received: via spool by 5251-done@debbugs.gnu.org id=D5251.14557244216254 (code D ref 5251); Wed, 17 Feb 2016 15:54:01 +0000 Original-Received: (at 5251-done) by debbugs.gnu.org; 17 Feb 2016 15:53:41 +0000 Original-Received: from localhost ([127.0.0.1]:39782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW4Q9-0001co-DK for submit@debbugs.gnu.org; Wed, 17 Feb 2016 10:53:41 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48581) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW4Q7-0001cX-Pd for 5251-done@debbugs.gnu.org; Wed, 17 Feb 2016 10:53:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW4Px-0006QT-Ml for 5251-done@debbugs.gnu.org; Wed, 17 Feb 2016 10:53:34 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW4Px-0006QP-JX; Wed, 17 Feb 2016 10:53:29 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4458 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aW4Pw-0003qx-MZ; Wed, 17 Feb 2016 10:53:29 -0500 In-reply-to: (message from Andrew Hyatt on Tue, 16 Feb 2016 22:41:32 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113188 Archived-At: > From: Andrew Hyatt > Date: Tue, 16 Feb 2016 22:41:32 -0500 > Cc: 5251@debbugs.gnu.org > > > I can verify that this issue still happens in Emacs 25. This simple fix > seems to have slipped by unnoticed many years ago, hopefully someone > that is qualified to comment on the patch will see it now. Thanks for the reminder, I fixed this now on the emacs-25 branch. (The proposed patch was not entirely correct, although it was in the right direction, and happened to fix this particular case.) It is indeed a shame that such a simple bug was left unresolved for such a long time, but better late than never. > BTW, this seems like a nice thing to unit test with ert, if a fix does > take place. Yes, that would be very welcome, thanks. Looks like coding-tests.el is a good place to add such a test. Please be sure to include lone ^M characters, as well as those followed by a newline, so that we are sure lone CRs are not removed. Thanks.