From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22787: [PATCH] Allocate glyph matrices for the initial frame Date: Wed, 24 Feb 2016 19:25:49 +0200 Message-ID: <8337sihvfm.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1456334844 20308 80.91.229.3 (24 Feb 2016 17:27:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Feb 2016 17:27:24 +0000 (UTC) Cc: 22787@debbugs.gnu.org To: Chris Feng Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 24 18:27:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aYdDT-0005xH-6R for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Feb 2016 18:27:11 +0100 Original-Received: from localhost ([::1]:37286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYdDS-0004oA-Kp for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Feb 2016 12:27:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYdDP-0004o4-Cn for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2016 12:27:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYdDK-0007Oa-A5 for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2016 12:27:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYdDK-0007OW-6o for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2016 12:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aYdDJ-0001S4-Th for bug-gnu-emacs@gnu.org; Wed, 24 Feb 2016 12:27:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2016 17:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22787 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22787-submit@debbugs.gnu.org id=B22787.14563347655520 (code B ref 22787); Wed, 24 Feb 2016 17:27:01 +0000 Original-Received: (at 22787) by debbugs.gnu.org; 24 Feb 2016 17:26:05 +0000 Original-Received: from localhost ([127.0.0.1]:44056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYdCP-0001Qy-DG for submit@debbugs.gnu.org; Wed, 24 Feb 2016 12:26:05 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39537) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYdCN-0001QT-FJ for 22787@debbugs.gnu.org; Wed, 24 Feb 2016 12:26:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYdCD-0006hc-Dn for 22787@debbugs.gnu.org; Wed, 24 Feb 2016 12:25:58 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYdCD-0006hY-A1; Wed, 24 Feb 2016 12:25:53 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3731 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aYdCB-0004DR-FS; Wed, 24 Feb 2016 12:25:52 -0500 In-reply-to: (message from Chris Feng on Wed, 24 Feb 2016 14:32:17 +0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113723 Archived-At: > Date: Wed, 24 Feb 2016 14:32:17 +0800 > From: Chris Feng > > After bd4de70f the initial frame is created without the glyph matrices > allocated. As a result Emacs in batch/daemon mode would crash when evaluating > certain functions (e.g. line-pixel-height, window-text-pixel-size). Thanks, but can you explain this part: > clear_glyph_matrix_rows (struct glyph_matrix *matrix, int start, int end) > { > eassert (start <= end); > - eassert (start >= 0 && start < matrix->nrows); > + eassert (start >= 0 && start <= matrix->nrows); If this is for the case that both start and matrix->nrows are zero, please test that case separately.