From: Eli Zaretskii <eliz@gnu.org>
To: Marcin Borkowski <mbork@mbork.pl>
Cc: 20871@debbugs.gnu.org
Subject: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren
Date: Sun, 17 Apr 2016 17:57:48 +0300 [thread overview]
Message-ID: <8337qkb7v7.fsf@gnu.org> (raw)
In-Reply-To: <87shyku4jt.fsf@mbork.pl> (message from Marcin Borkowski on Sun, 17 Apr 2016 08:34:30 +0200)
> From: Marcin Borkowski <mbork@mbork.pl>
> Date: Sun, 17 Apr 2016 08:34:30 +0200
>
> >> today I found that fill-single-char-nobreak-p is just a bit too
> >> simplistic. When point is after e.g. the string " (a", it returns nil
> >> instead of t. I am not sure which characters should be added to the
> >> regex, but at least the opening paren (and maybe bracket) should be
> >> there, so I'd change the regex into [[:space:]][[(]*[[:alpha:]]. (Two
> >> or more opening parens/brackets are unlikely, but when in doubt, I guess
> >> it's better to return t than nil than the other way round.)
> >>
> >> Best regards,
> >
> > Just noticed that there is a hardcoded (backward-char 2), so it
> > seems that adding a few characters to the regex is not enough. Maybe
> > looking-back is the way to go (though it might slow filling down)?
> > I don't know.
>
> Hi there,
>
> so here's a patch for the bug I reported some time ago.
Could you please elaborate on the bug itself?
See, the function in question, fill-single-char-nobreak-p, is
documented as a possible value to use in the fill hook, for a very
specific purpose. If you are saying that it doesn't fulfill that
purpose well enough, please show a use case where it fails to do that.
At least the situation you described, with " (a", doesn't seem to fit
the use cases which this function is supposed to cover, since the
parenthesis makes a 2-character sequence, whereas
fill-single-char-nobreak-p aims to support isolated one-character
words.
I also am not sure I understand what is so special about '(' that it
has to be hard-coded here. What about '[' or '{' or '<' (or any other
punctuation character, for that matter)?
> Please review both the patch and the commit message (I'm still
> learning to write them...).
The commit message should begin with a capital letter. Also, I think
this variant is more clear:
Don't break after a single-character word that follows an opening
parenthesis.
Thanks.
next prev parent reply other threads:[~2016-04-17 14:57 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 10:19 bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren Marcin Borkowski
2015-06-22 10:28 ` Marcin Borkowski
2016-04-17 6:34 ` Marcin Borkowski
2016-04-17 14:57 ` Eli Zaretskii [this message]
2016-04-17 15:34 ` Marcin Borkowski
2016-04-17 16:49 ` Eli Zaretskii
2016-04-17 17:41 ` Marcin Borkowski
2016-04-27 7:02 ` Marcin Borkowski
2016-04-27 7:20 ` Eli Zaretskii
2016-04-29 12:18 ` Marcin Borkowski
2016-04-30 11:21 ` Eli Zaretskii
2016-04-30 12:26 ` Marcin Borkowski
2016-04-30 12:38 ` Eli Zaretskii
2016-04-30 16:41 ` Marcin Borkowski
2016-04-30 17:01 ` Eli Zaretskii
2016-04-30 18:42 ` Marcin Borkowski
2016-04-30 19:01 ` Eli Zaretskii
2017-12-07 13:28 ` Marcin Borkowski
2017-12-09 11:52 ` Eli Zaretskii
2017-12-09 15:45 ` Marcin Borkowski
2017-12-19 11:44 ` Marcin Borkowski
2017-12-19 16:15 ` Eli Zaretskii
2018-01-02 8:55 ` Marcin Borkowski
2018-01-13 8:46 ` Eli Zaretskii
2018-01-13 16:01 ` Marcin Borkowski
2018-01-13 16:53 ` Eli Zaretskii
2018-01-13 17:02 ` Eli Zaretskii
2018-01-15 5:13 ` Marcin Borkowski
2018-01-15 5:13 ` Marcin Borkowski
2018-01-15 5:30 ` Marcin Borkowski
2018-01-15 13:07 ` Eli Zaretskii
2018-01-24 9:34 ` Marcin Borkowski
2018-01-24 19:16 ` Eli Zaretskii
2016-04-30 17:42 ` Drew Adams
2016-04-30 18:24 ` Eli Zaretskii
2016-04-30 18:41 ` Marcin Borkowski
2018-02-02 9:18 ` Michal Nazarewicz
[not found] <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org>
[not found] ` <8336i1p8zd.fsf@gnu.org>
[not found] ` <CA+pa1O3rcDznoR0u8i_AN5iHe9mM+FHqkAO=yVM2Gu5_Gc40jQ@mail.gmail.com>
2019-08-17 6:57 ` Eli Zaretskii
2019-08-17 14:17 ` Marcin Borkowski
2019-08-17 15:04 ` Eli Zaretskii
2019-08-17 15:58 ` Marcin Borkowski
2019-08-19 14:07 ` Michał Nazarewicz
2019-08-19 15:01 ` Eli Zaretskii
2019-08-19 15:36 ` Michał Nazarewicz
2019-08-19 16:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8337qkb7v7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20871@debbugs.gnu.org \
--cc=mbork@mbork.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.