From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Note on e65c307 breaks font-height Date: Sat, 28 May 2016 13:17:58 +0300 Message-ID: <8337p2zdt5.fsf@gnu.org> References: <5746D38F.4010203@gmx.at> <4cdc1b55-2fe2-2457-1115-33ff68a9a65d@cs.ucla.edu> <5748490A.6020906@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1464430686 22397 80.91.229.3 (28 May 2016 10:18:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 May 2016 10:18:06 +0000 (UTC) Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 28 12:18:01 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b6bJg-0007oy-Fs for ged-emacs-devel@m.gmane.org; Sat, 28 May 2016 12:18:00 +0200 Original-Received: from localhost ([::1]:52846 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6bJf-0004eN-Oc for ged-emacs-devel@m.gmane.org; Sat, 28 May 2016 06:17:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6bJZ-0004eF-Qr for emacs-devel@gnu.org; Sat, 28 May 2016 06:17:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6bJW-0008WD-GN for emacs-devel@gnu.org; Sat, 28 May 2016 06:17:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6bJW-0008W2-D6; Sat, 28 May 2016 06:17:50 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1389 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b6bJU-0006QH-4B; Sat, 28 May 2016 06:17:48 -0400 In-reply-to: <5748490A.6020906@gmx.at> (message from martin rudalics on Fri, 27 May 2016 15:18:02 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204106 Archived-At: > Date: Fri, 27 May 2016 15:18:02 +0200 > From: martin rudalics > > > What exactly is in your .emacs file? That is, can you give a recipe to reproduce the problem? > > It's reproducible here with my > > (custom-set-faces > ;; custom-set-faces was added by Custom. > ;; If you edit it by hand, you could mess it up, so be careful. > ;; Your init file should contain only one such instance. > ;; If there is more than one, they won't work right. > '(default ((t (:stipple nil :background "grey92" :foreground "black" :inverse-video nil :box nil :strike-through nil :overline nil :underline nil :slant normal :weight normal :height 98 :width normal :foundry "outline" :family "Courier New"))))) Any reasons why you prefer specifying each of the font's attributes separately, instead of just specifying a font? IOW, how is the above different from something like (add-to-list 'default-frame-alist '(font . "-outline-Courier New-normal-r-normal-normal-15-112-96-96-c-90-iso8859-1")) (in your case, you may wish changing the size numbers, I think)? The advantage of the full font specification is that it works around the subtleties of the Emacs font selection procedure, whereby it could effectively disregard some of the attributes as result. > My analysis so far is as follows: In ‘font-setting-change-default-font’ > the disjunct (frame-parameter f 'font-parameter) always evaluates to > nil here. Before your patch, the disjunct > > (or (font-get (face-attribute 'default :font f 'default) > :user-spec) Why are we looking at the :font attribute, when you say the problematic attribute is :height? Anyway, I think the best way forward is to debug Emacs during startup, putting a breakpoint where the :height attribute is being processed, and see what happens before and after Paul's change of the :user-spec symbol's definition. (My guess is that the change is correct, and the problems it uncovers are either unrelated bugs, or something that isn't supposed to work in the first place, at least not reliably.)