From: Eli Zaretskii <eliz@gnu.org>
To: sbaugh@catern.com
Cc: 23899-done@debbugs.gnu.org
Subject: bug#23899: 24.5; mouse-on-link-p breaks for positions
Date: Thu, 07 Jul 2016 19:16:20 +0300 [thread overview]
Message-ID: <8337nll8yz.fsf@gnu.org> (raw)
In-Reply-To: <87zipw9eim.fsf@earth.catern.com> (sbaugh@catern.com)
> From: sbaugh@catern.com
> Date: Tue, 05 Jul 2016 13:32:49 -0400
>
> The documentation for mouse-on-link-p says:
> POS must be a buffer position in the current buffer or a mouse
> event location in the selected window (see `event-start').
> However, doing M-: (mouse-on-link-p (point)) fails with a type
> error. And, in general, passing a buffer position to mouse-on-link-p
> fails with a type error.
>
> This appears to be due to this section of mouse-on-link-p:
> (let ((area (posn-area pos)))
> (when area
> (key-binding (vector area 'follow-link) nil t pos)))
>
> I would recommend wrapping this in a (and (consp pos) ...) to avoid
> running posn-area on buffer positions. The rest of the function works
> fine, this part was added later.
I don't think any code changes are required. This is just a
documentation problem: what the doc string fails to tell is that the
function needs POS as a mouse-click position, which is a list. If you
want to invoke the function at point, you can get the argument by
calling posn-at-point.
I installed a change to that effect on the emacs-25 branch, and I'm
marking this bug "done".
Thanks.
prev parent reply other threads:[~2016-07-07 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 17:32 bug#23899: 24.5; mouse-on-link-p breaks for positions sbaugh
2016-07-07 16:16 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8337nll8yz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23899-done@debbugs.gnu.org \
--cc=sbaugh@catern.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.