From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Compilation warnings in mouse.el Date: Tue, 12 Jul 2016 08:04:57 +0300 Message-ID: <8337nfcupy.fsf@gnu.org> References: <8360scdzik.fsf@gnu.org> <87zipnzvo4.fsf@gmx.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1468299962 22205 80.91.229.3 (12 Jul 2016 05:06:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 05:06:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Berman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 12 07:05:58 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMptJ-0007uT-9G for ged-emacs-devel@m.gmane.org; Tue, 12 Jul 2016 07:05:53 +0200 Original-Received: from localhost ([::1]:37424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMptI-00008x-I8 for ged-emacs-devel@m.gmane.org; Tue, 12 Jul 2016 01:05:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMpsn-0008Ml-0H for emacs-devel@gnu.org; Tue, 12 Jul 2016 01:05:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMpsh-0001jk-VI for emacs-devel@gnu.org; Tue, 12 Jul 2016 01:05:19 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMpsh-0001jZ-Re; Tue, 12 Jul 2016 01:05:15 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4389 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bMpsf-0000CO-Si; Tue, 12 Jul 2016 01:05:14 -0400 In-reply-to: <87zipnzvo4.fsf@gmx.net> (message from Stephen Berman on Mon, 11 Jul 2016 23:55:55 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205565 Archived-At: > From: Stephen Berman > Cc: emacs-devel@gnu.org > Date: Mon, 11 Jul 2016 23:55:55 +0200 > > > mouse.el:541:1:Warning: defcustom for `mouse-select-region-move-to-beginning' > > fails to specify containing group > > mouse.el:541:1:Warning: defcustom for `mouse-select-region-move-to-beginning' > > fails to specify containing group > > Sorry about that. I saw that the other defcustoms in mouse.el have a > ":group 'mouse" line and wrongly assumed this group was defined. So > should I just add ":group 'mouse" to that defcustom or instead add a > defgroup to mouse.el and remove the existing ":group 'mouse" lines? Unlike Stefan, I think we should add :group to every defcustom. Having them mysteriously missing from some of them is a time bomb: remove or add enough defcustoms in the same file, and you have a bug. Are there any downsides to having :group in all defcustoms?