From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23949: 25.0.95; Regression in handling error caused by (string-match-p "." nil) Date: Wed, 13 Jul 2016 18:17:24 +0300 Message-ID: <8337nda7p7.fsf@gnu.org> References: <83lh17ati6.fsf@gnu.org> <83h9bvarb6.fsf@gnu.org> <83mvllaa4u.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1468423117 30513 80.91.229.3 (13 Jul 2016 15:18:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2016 15:18:37 +0000 (UTC) Cc: 23949@debbugs.gnu.org, monnier@iro.umontreal.ca, kaushal.modi@gmail.com To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 13 17:18:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNLvX-0001Og-R1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jul 2016 17:18:19 +0200 Original-Received: from localhost ([::1]:48361 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNLvR-0007vB-SX for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Jul 2016 11:18:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNLvM-0007oJ-0X for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 11:18:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNLvG-0006ic-Od for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 11:18:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNLvG-0006iT-LQ for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 11:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bNLvG-0004FU-HO for bug-gnu-emacs@gnu.org; Wed, 13 Jul 2016 11:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2016 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23949-submit@debbugs.gnu.org id=B23949.146842307416316 (code B ref 23949); Wed, 13 Jul 2016 15:18:02 +0000 Original-Received: (at 23949) by debbugs.gnu.org; 13 Jul 2016 15:17:54 +0000 Original-Received: from localhost ([127.0.0.1]:49985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNLv7-0004F5-J1 for submit@debbugs.gnu.org; Wed, 13 Jul 2016 11:17:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNLv5-0004Es-9d for 23949@debbugs.gnu.org; Wed, 13 Jul 2016 11:17:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNLuz-0006fj-Ex for 23949@debbugs.gnu.org; Wed, 13 Jul 2016 11:17:46 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNLuu-0006fD-PD; Wed, 13 Jul 2016 11:17:40 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3871 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bNLus-0005T7-QZ; Wed, 13 Jul 2016 11:17:39 -0400 In-reply-to: (message from Andreas Schwab on Wed, 13 Jul 2016 17:03:22 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121007 Archived-At: > From: Andreas Schwab > Cc: Stefan Monnier , 23949@debbugs.gnu.org, kaushal.modi@gmail.com > Date: Wed, 13 Jul 2016 17:03:22 +0200 > > > (defsubst string-match-p (regexp string &optional start) > > "\ > > Same as `string-match' except this function does not change the match data." > > (condition-case err > > (let ((inhibit-changing-match-data t)) > > (string-match regexp string start)) > > (error (signal (car err) (cdr err))))) > > This optimizes for the rare case that string-match throws an error. > Better would be to bind inhibit-changing-match-data in call_debugger. Fine, let's do that, then. Thanks.