From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24580: 25.2.50; query-replace history doesn't work Date: Sun, 02 Oct 2016 10:02:42 +0300 Message-ID: <8337kfkzcd.fsf@gnu.org> References: <87fuogh8mo.fsf@mbork.pl> <83y428lawc.fsf@gnu.org> <20161002041715.GA5612@holos.localdomain> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1475391800 13626 195.159.176.226 (2 Oct 2016 07:03:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Oct 2016 07:03:20 +0000 (UTC) Cc: mbork@mbork.pl, 24580@debbugs.gnu.org To: Mark Oteiza Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 02 09:03:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqanq-0002l1-3b for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Oct 2016 09:03:14 +0200 Original-Received: from localhost ([::1]:58366 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqann-0005Ll-O0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Oct 2016 03:03:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqang-0005Lc-83 for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 03:03:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqane-00043Q-Nv for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 03:03:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqane-00043M-K3 for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 03:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bqane-0003Ds-Aq for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2016 03:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2016 07:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24580 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24580-submit@debbugs.gnu.org id=B24580.147539176512364 (code B ref 24580); Sun, 02 Oct 2016 07:03:02 +0000 Original-Received: (at 24580) by debbugs.gnu.org; 2 Oct 2016 07:02:45 +0000 Original-Received: from localhost ([127.0.0.1]:41473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqanN-0003DM-BI for submit@debbugs.gnu.org; Sun, 02 Oct 2016 03:02:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bqanL-0003D4-Ax for 24580@debbugs.gnu.org; Sun, 02 Oct 2016 03:02:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bqanC-0003ve-Oy for 24580@debbugs.gnu.org; Sun, 02 Oct 2016 03:02:37 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bqanC-0003v6-LP; Sun, 02 Oct 2016 03:02:34 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2941 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bqanA-0000bZ-MP; Sun, 02 Oct 2016 03:02:33 -0400 In-reply-to: <20161002041715.GA5612@holos.localdomain> (message from Mark Oteiza on Sun, 2 Oct 2016 00:17:15 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123887 Archived-At: > Date: Sun, 2 Oct 2016 00:17:15 -0400 > From: Mark Oteiza > Cc: Marcin Borkowski , 24580@debbugs.gnu.org > > > > - start emacs -Q > > > - press `a' `C-b', `M-%', `a', `RET', `b', `RET', `!' > > > - press `M-%', `M-p' > > > > > > Emacs says "Beginning of history; no preceding item". > > > > Mark, this regression was caused by the lexical-binding change in > > replace.el. Could you please take a look? > > The problem lies (at least) in query-replace-read-from, where > query-replace-from-to is let bound, and later read-from-minibuffer > refers to the symbol 'query-replace-from-to. At first sight, it looks > like it could be fixed by putting some of the setup done by these > bindings into the minibuffer setup hook. Isn't there a less intrusive change to fix this? A significant change like the one you propose is more risky, but if there's no safer one, I guess we should take it. > As for the other problem Marcin mentioned, that seems to be due to the > custom-reevaluate-setting call in the same function. I'm not sure I understand: what's wrong with custom-reevaluate-setting in this case? Thanks.