From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21804: 25.0.50; file-notify-tests failure on Cygwin Date: Sat, 31 Dec 2016 10:26:53 +0200 Message-ID: <8337h4ijw2.fsf@gnu.org> References: <563634F7.2070606@cornell.edu> <8737wpipy8.fsf@gmx.de> <87a8qv6lu2.fsf@gmx.de> <5639818A.5090307@cornell.edu> <87ziyugoqr.fsf@gmx.de> <563A3890.6030707@cornell.edu> <87si4lhaeq.fsf@gmx.de> <563ACB3F.5080709@cornell.edu> <87y4ecnrpp.fsf@gmx.de> <87r34tmv9m.fsf@gmx.de> <87h95pp6dd.fsf@gmx.de> <87zijek10s.fsf@gmx.de> <83a8bdu7gl.fsf@gnu.org> <87vau1jkx2.fsf@gmx.de> <52f2d693-8688-f556-fa35-b74b4b21f566@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1483172895 31482 195.159.176.226 (31 Dec 2016 08:28:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 31 Dec 2016 08:28:15 +0000 (UTC) Cc: michael.albinus@gmx.de, 21804@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 31 09:28:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNF1M-000783-Rl for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Dec 2016 09:28:09 +0100 Original-Received: from localhost ([::1]:42956 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNF1Q-0001RF-71 for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Dec 2016 03:28:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36753) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNF1K-0001Qx-7M for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 03:28:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNF1G-0001HQ-BA for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 03:28:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45421) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cNF1G-0001HE-7e for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 03:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cNF1G-00032R-2B for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2016 03:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Dec 2016 08:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21804 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21804-submit@debbugs.gnu.org id=B21804.148317282511604 (code B ref 21804); Sat, 31 Dec 2016 08:28:02 +0000 Original-Received: (at 21804) by debbugs.gnu.org; 31 Dec 2016 08:27:05 +0000 Original-Received: from localhost ([127.0.0.1]:60820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNF0K-000316-Mi for submit@debbugs.gnu.org; Sat, 31 Dec 2016 03:27:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNF0J-00030Z-0K for 21804@debbugs.gnu.org; Sat, 31 Dec 2016 03:27:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNF0A-0000kK-0K for 21804@debbugs.gnu.org; Sat, 31 Dec 2016 03:26:57 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNF09-0000kG-To; Sat, 31 Dec 2016 03:26:53 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3888 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cNF08-00013G-Vs; Sat, 31 Dec 2016 03:26:53 -0500 In-reply-to: <52f2d693-8688-f556-fa35-b74b4b21f566@cornell.edu> (message from Ken Brown on Fri, 30 Dec 2016 17:19:03 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127615 Archived-At: > Cc: 21804@debbugs.gnu.org > From: Ken Brown > Date: Fri, 30 Dec 2016 17:19:03 -0500 > > On 12/30/2016 2:07 PM, Michael Albinus wrote: > > Eli Zaretskii writes: > > > >>> - (string-equal (file-notify--test-monitor) "GPollFileMonitor")) > >>> + (or (string-equal (file-notify--test-monitor) "GPollFileMonitor") > >>> + (string-equal (file-notify--test-monitor) "GFamFileMonitor"))) > >> > >> Wouldn't it be better if gfile-monitor-name returned a symbol instead > >> of a string? That's our general convention with functions, I think. > > > > I've changed it accordingly. > > But since it returns an uninterned symbol, I think I still need to use > string-equal above. Or am I misunderstanding something? I actually don't understand why Michael decided to return an uninterned symbol here.