From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28439: suggestion: support case-independent xref-find-definitions prompt TAB Date: Thu, 14 Sep 2017 20:01:36 +0300 Message-ID: <83377pnrin.fsf@gnu.org> References: <201709122237.v8CMb6w0029533@psr.com> <83r2vaobtn.fsf@gnu.org> <9b90e72d-e07b-a519-6693-c22c8722d83b@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505408540 17757 195.159.176.226 (14 Sep 2017 17:02:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 14 Sep 2017 17:02:20 +0000 (UTC) Cc: wbe@psr.com, 28439@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 14 19:02:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsXWi-0004G2-RC for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Sep 2017 19:02:08 +0200 Original-Received: from localhost ([::1]:48999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsXWo-0006Ye-MT for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Sep 2017 13:02:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsXWh-0006YR-VA for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 13:02:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsXWc-0008Fd-FM for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 13:02:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60881) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dsXWc-0008FW-CS for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 13:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dsXWb-0000Zu-U9 for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 13:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Sep 2017 17:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28439 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: wbe@psr.com, bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15054085121767 (code B ref -1); Thu, 14 Sep 2017 17:02:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Sep 2017 17:01:52 +0000 Original-Received: from localhost ([127.0.0.1]:41328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsXWP-0000QL-PV for submit@debbugs.gnu.org; Thu, 14 Sep 2017 13:01:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dsXWN-0000Jl-Pq for submit@debbugs.gnu.org; Thu, 14 Sep 2017 13:01:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsXWH-00082Q-CJ for submit@debbugs.gnu.org; Thu, 14 Sep 2017 13:01:42 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:53493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsXWH-00082E-9F for submit@debbugs.gnu.org; Thu, 14 Sep 2017 13:01:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsXWD-0006K0-1T for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 13:01:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsXWA-0007w7-0S for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2017 13:01:37 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsXW9-0007w3-U3; Thu, 14 Sep 2017 13:01:33 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1270 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dsXW9-0000OX-DJ; Thu, 14 Sep 2017 13:01:33 -0400 In-reply-to: <9b90e72d-e07b-a519-6693-c22c8722d83b@yandex.ru> (message from Dmitry Gutov on Thu, 14 Sep 2017 02:04:10 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136964 Archived-At: > Cc: bug-gnu-emacs@gnu.org > From: Dmitry Gutov > Date: Thu, 14 Sep 2017 02:04:10 +0300 > > >> Since xref-find-definitions is willing to match names typed in all > >> lower case to mixed case names, TAB (show alternatives) should, too. > >> If there's not already a way to make TAB do so, then a way should be > >> added. > > > > Dmitry, how about the patch below? > > Sorry, what don't we want to follow the value of completion-ignore-case? Because it has a much broader effect. And because the issue here is inconsistency between completion and actual matching in xref-find-definitions. They should be consistent, IMO. > The fact that we have the option tags-case-fold-search (used in > find-tag-tag, among other places) probably means that some users prefer > not to ignore case. Then maybe an alternative is to make tags-case-fold-search nil by default? Or make xref--read-identifier be case-insensitive if case-fold-search is non-nil? > Maybe we could add a similar xref-specific option on top, but I'm not > sure why completion-ignore-case is not good enough. > > We could change its default to t, though. Emacs-wide? Or just when completing on identifiers?