From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * src/editfns.c (Fchar_after): Small optimization. Date: Sat, 30 Sep 2017 22:05:51 +0300 Message-ID: <8337743t2o.fsf@gnu.org> References: <20170930184111.41806-1-phst@google.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1506798425 659 195.159.176.226 (30 Sep 2017 19:07:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 30 Sep 2017 19:07:05 +0000 (UTC) Cc: phst@google.com, emacs-devel@gnu.org To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 30 21:07:01 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyN6I-0007lf-01 for ged-emacs-devel@m.gmane.org; Sat, 30 Sep 2017 21:06:58 +0200 Original-Received: from localhost ([::1]:40135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyN6M-00013C-Am for ged-emacs-devel@m.gmane.org; Sat, 30 Sep 2017 15:07:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyN5a-00012E-Mn for emacs-devel@gnu.org; Sat, 30 Sep 2017 15:06:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dyN5Z-0005OS-T0 for emacs-devel@gnu.org; Sat, 30 Sep 2017 15:06:14 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dyN5S-0005KD-T1; Sat, 30 Sep 2017 15:06:06 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4277 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dyN5R-0003dj-FI; Sat, 30 Sep 2017 15:06:06 -0400 In-reply-to: <20170930184111.41806-1-phst@google.com> (message from Philipp Stephani on Sat, 30 Sep 2017 20:41:11 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218975 Archived-At: > From: Philipp Stephani > Date: Sat, 30 Sep 2017 20:41:11 +0200 > Cc: Philipp Stephani > > --- > src/editfns.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/editfns.c b/src/editfns.c > index b03eb947de..e87c682f97 100644 > --- a/src/editfns.c > +++ b/src/editfns.c > @@ -1256,10 +1256,10 @@ If POS is out of range, the value is nil. */) > if (NILP (pos)) > { > pos_byte = PT_BYTE; > - XSETFASTINT (pos, PT); > + if (pos_byte == ZV_BYTE) <<<<<<<<<<<<<<<<<<<<<< > + return Qnil; The comparison should use >=, not just ==, because PT could be temporarily out of bounds. I've seen Lisp hooks which cause such calamities. For the same reason, we should also check that PT_BYTE is not smaller than BEGV_BYTE. Thanks.